Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

collateral support in the builder #442

Merged
merged 22 commits into from
Jun 5, 2022
Merged

collateral support in the builder #442

merged 22 commits into from
Jun 5, 2022

Conversation

vsubhuman
Copy link
Contributor

No description provided.

@vsubhuman
Extracted tx_inputs_builder. Added tx_builder.set_inputs and `tx_bu…
8fbc488 
…ilder.set_collateral`. Deprecated old methods to add inputs in the builder.
@vsubhuman vsubhuman modified the milestones: 10.3.0, 10.2.0 May 26, 2022
@vsubhuman vsubhuman linked an issue May 26, 2022 that may be closed by this pull request
Add collateral error to tx building #316
Closed
@vsubhuman vsubhuman requested a review from lisicky May 26, 2022 12:13
vsubhuman
vsubhuman commented May 31, 2022
View reviewed changes
Copy link
Contributor Author

@vsubhuman vsubhuman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/check

vsubhuman
vsubhuman commented May 31, 2022
View reviewed changes
Copy link
Contributor Author

@vsubhuman vsubhuman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/check

@vsubhuman vsubhuman marked this pull request as ready for review June 1, 2022 11:55
vsubhuman
vsubhuman commented Jun 1, 2022
View reviewed changes
Copy link
Contributor Author

@vsubhuman vsubhuman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/check

@vsubhuman
Changed the tx-inputs-builder to store inputs in a sorted map. Added …
d5b93bb 
…`tx_builder.add_required_signer`. Fixed tests. Beta version bump.
vsubhuman
vsubhuman commented Jun 2, 2022
View reviewed changes
Copy link
Contributor Author

@vsubhuman vsubhuman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/check

vsubhuman
vsubhuman commented Jun 4, 2022
View reviewed changes
Copy link
Contributor Author

@vsubhuman vsubhuman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/check

vsubhuman
vsubhuman commented Jun 5, 2022
View reviewed changes
Copy link
Contributor Author

@vsubhuman vsubhuman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/check

@vsubhuman vsubhuman merged commit ca6bf73 into master Jun 5, 2022
@vsubhuman vsubhuman deleted the ruslan/tx-builder-collateral branch June 5, 2022 06:47
@vsubhuman vsubhuman mentioned this pull request Jun 5, 2022
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lisicky lisicky lisicky approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
10.2.0
Development

Successfully merging this pull request may close these issues.

Add collateral error to tx building
2 participants
@vsubhuman @lisicky