[4.13.100] Optimize initialization speed #2841
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yushih
force-pushed
the
yushi/startup-speed-1
branch
from
69f3416 to
fb837bf
Compare
yushih
changed the title
neuodev
reviewed
May 6, 2022
packages/yoroi-extension/app/components/common/CheckboxLabel.js
Outdated
Show resolved
Hide resolved
neuodev
reviewed
May 6, 2022
neuodev
previously approved these changes
May 6, 2022
neuodev
dismissed
their stale review
Not all import statements for SVGs is updated! this might cause crash for the extension when navigating to these page
yushih
force-pushed
the
yushi/startup-speed-1
branch
2 times, most recently
from
e34ac57 to
9992d54
Compare
yushih
force-pushed
the
yushi/startup-speed-1
branch
from
9204e71 to
6719315
Compare
vsubhuman
changed the title
vsubhuman
reviewed
May 13, 2022
| @@ -39,7 +39,10 @@ export const generateAdaPaperPdf = async ( | |||
|
|
|||
| const width = 595.28; | |||
| const height = 841.98; | |||
| const doc = new Pdf({ | |||
|
|
|||
| const JsPdf = (await import('jspdf')).default; | |||
vsubhuman
previously approved these changes
May 13, 2022
vsubhuman
requested changes
May 13, 2022
vsubhuman
previously approved these changes
May 13, 2022
yushih
commented
May 13, 2022
| @@ -17,5 +17,6 @@ module.exports = { | |||
| 'jest-canvas-mock' | |||
| ], | |||
| // ignore manifest.test.js file, because it isn't a test | |||
| testPathIgnorePatterns: ['manifest.test.js'] | |||
| testPathIgnorePatterns: ['manifest.test.js'], | |||
| modulePathIgnorePatterns: ['jormungandr'], | |||
There was a problem hiding this comment.
Oops, forgot about this.
vsubhuman
previously approved these changes
May 13, 2022
Nebyt
previously approved these changes
May 14, 2022
Nebyt
previously approved these changes
May 14, 2022
vsubhuman
force-pushed
the
yushi/startup-speed-1
branch
from
db42116 to
da647f0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please review commit c5d2601 individual if it helps.
ee7d093 makes perceived loading speed faster by loading wallet data after the main UI starts to render.
80f8576 loads SVGs on-demand (some of them are huge but rarely used). But because of it, all the SVG import statements need to be rewritten: c5d2601 is just mechanical changing of all import syntax for SVGs. Also, flow type of SVG imports must be fixed by bd83cd2.
Other commits should be straightforward by the commit messages.