Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add Intl & layout fixes for the connected dApps page #3205

Merged
merged 3 commits into from
May 19, 2023
Merged

fix: add Intl & layout fixes for the connected dApps page #3205

merged 3 commits into from
May 19, 2023

Conversation

neuodev
Copy link
Contributor

@neuodev neuodev commented May 13, 2023

No description provided.

@neuodev neuodev requested review from vsubhuman and Nebyt May 13, 2023 16:44
@neuodev neuodev self-assigned this May 13, 2023
@neuodev
Copy link
Contributor Author

neuodev commented May 13, 2023

[autoscirpt] Jira Ticket: Long dApp URL causes the layout to be broken

vsubhuman
vsubhuman requested changes May 15, 2023
View reviewed changes
Copy link
Contributor

@vsubhuman vsubhuman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@neuodev , plz roll back any code-style diff not related to the functional change in the PR, it is greatly complicating the review process. If you want to, you can make a separate PR with style fixes, but then it should have no functional changes at all. /check

@vsubhuman
Merge remote-tracking branch 'origin/develop' into fix/YOEXT-601/dapp…
c7051de 
…-url

# Conflicts:
#	packages/yoroi-extension/app/components/dapp-connector/ConnectedWebsites/ConnectedWebsitesPage.js
@vsubhuman vsubhuman added this to the 4.21.0 milestone May 19, 2023
@sonarqube-yoroi
Copy link

SonarQube Quality Gate

Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@vsubhuman vsubhuman merged commit b39c14a into develop May 19, 2023
@vsubhuman vsubhuman deleted the fix/YOEXT-601/dapp-url branch May 19, 2023 12:14
@vsubhuman vsubhuman mentioned this pull request May 19, 2023
Merged
10 tasks
@neuodev
Copy link
Contributor Author

neuodev commented May 22, 2023

@neuodev , plz roll back any code-style diff not related to the functional change in the PR, it is greatly complicating the review process. If you want to, you can make a separate PR with style fixes, but then it should have no functional changes at all. /check

Sorry, just saw your comment! nice idea about a specific PR for formatting changes! Will make one if needed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nebyt Nebyt Nebyt approved these changes

@vsubhuman vsubhuman vsubhuman approved these changes

Assignees

@neuodev neuodev

Labels
None yet
Projects
None yet
Milestone
4.21.0
Development

Successfully merging this pull request may close these issues.
3 participants
@neuodev @vsubhuman @Nebyt