[fix/4.22.400] changed CardanoAPI to function as a singleton with no dependency on this
#3267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[autoscirpt] Jira Ticket: [External] User is not able to unlock liquidity on dApp |
Nebyt
previously approved these changes
Aug 25, 2023
|
SonarQube Quality Gate
|
This was referenced Aug 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some users are encountering issues, when using certain dApps, that
CardanoAPIfunctions are being called with undefinedthis, which is most probably caused by said dApps calling the functions as higher order and not using.bindto do it properly. Rather than telling users to go and report it to these dApps to use instances properly, we can just make an update on our side and change the api to function as a singleton internally, since logically there is no real reason to ever have more than a single instance of it anyway. The usage ofthisis removed in the API object entirely.