Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable ergo dapp connector #3334

Merged
merged 2 commits into from
Oct 28, 2023
Merged

Disable ergo dapp connector #3334

merged 2 commits into from
Oct 28, 2023

Conversation

vsubhuman
Copy link
Contributor

  1. Removed ergo injector
  2. Removed ergo dapp example
  3. Removed ergo warning banner
  4. Removed some of the unused ergo code from the connector.

@vsubhuman
Removed ergo injector, ergo dapp example, ergo warning banner, and so…
df238e6 
…me of the unused ergo code from the connector.
@vsubhuman vsubhuman added this to the 4.23.0 milestone Oct 28, 2023
@vsubhuman vsubhuman requested review from yushih and Nebyt October 28, 2023 20:18
@neuodev
Copy link
Contributor

neuodev commented Oct 28, 2023

[autoscirpt] Jira Ticket: Disable ergo dapp-connector

vsubhuman
vsubhuman commented Oct 28, 2023
View reviewed changes
Copy link
Contributor Author

@vsubhuman vsubhuman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/check

@vsubhuman vsubhuman mentioned this pull request Oct 28, 2023
Merged
24 tasks
@sonarqube-yoroi
Copy link

SonarQube Quality Gate

Quality Gate failed

Failed condition E Maintainability Rating on New Code (is worse than A)

See analysis details on SonarQube

Fix issues before they fail your Quality Gate with SonarLint SonarLint in your IDE.

@vsubhuman vsubhuman merged commit a7c2c16 into release/4.23 Oct 28, 2023
5 of 12 checks passed
@vsubhuman vsubhuman deleted the feat/YOEXT-636/disable-ergo-dapp-connector branch October 28, 2023 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yushih yushih Awaiting requested review from yushih

@Nebyt Nebyt Awaiting requested review from Nebyt

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.23.0
Development

Successfully merging this pull request may close these issues.
2 participants
@vsubhuman @neuodev