Chore/yoext 940/eliminate warnings #3365

yushih · 2023-12-11T10:25:22Z

Many warnings are due to block elements nested inside . So replace by <div>. Also add component="div" to <Typography> to avoid generating .

neuodev · 2023-12-11T10:25:36Z

[autoscirpt] Jira Ticket: Get rid of some console warnings

nistadev

Overall looks good, nothing critical. I would use span instead of div on Typoghaphy components tho.

nistadev · 2023-12-11T11:30:27Z

packages/yoroi-extension/app/components/profile/nightly/NightlyForm.js

@@ -163,17 +163,17 @@ class NightlyForm extends Component<Props & InjectedLayoutProps, State> {
                  pl: '4px',
                }}
              >
-                <Typography component="li" variant="body1" lineHeight="24px">
+                <Typography component="div" component="li" variant="body1" lineHeight="24px">


Remove component="div" since we have another component defined.

nistadev · 2023-12-11T11:30:33Z

packages/yoroi-extension/app/components/profile/nightly/NightlyForm.js

                  {intl.formatMessage(messages.warning1)}
                </Typography>
-                <Typography component="li" variant="body1" lineHeight="24px">
+                <Typography component="div" component="li" variant="body1" lineHeight="24px">


Remove component="div" since we have another component defined.

nistadev · 2023-12-11T11:30:44Z

packages/yoroi-extension/app/components/profile/nightly/NightlyForm.js

@@ -183,10 +183,10 @@ class NightlyForm extends Component<Props & InjectedLayoutProps, State> {
                  pl: '4px',
                }}
              >
-                <Typography component="li" variant="body1" lineHeight="24px">
+                <Typography component="div" component="li" variant="body1" lineHeight="24px">


Remove component="div" since we have another component defined.

nistadev · 2023-12-11T11:30:50Z

packages/yoroi-extension/app/components/profile/nightly/NightlyForm.js

                  {intl.formatMessage(messages.recommendation1)}
                </Typography>
-                <Typography component="li" variant="body1" lineHeight="24px">
+                <Typography component="div" component="li" variant="body1" lineHeight="24px">


Remove component="div" since we have another component defined.

nistadev · 2023-12-11T11:31:13Z

packages/yoroi-extension/app/components/settings/categories/SupportSettings.js

@@ -102,7 +102,7 @@ class SupportSettings extends Component<Props & InjectedProps> {
    return (
      <Box>
        {isRevampLayout && (
-          <Typography component="h5" variant="h5" mb="24px" color="common.black" fontWeight={500}>
+          <Typography component="div" component="h5" variant="h5" mb="24px" color="common.black" fontWeight={500}>


Remove component="div" since we have another component defined.

nistadev · 2023-12-11T11:54:19Z

packages/yoroi-extension/app/components/wallet/transactions/TransactionRevamp.js

@@ -314,7 +314,7 @@ export default class TransactionRevamp extends Component<Props, State> {
  |}) => Node = request => {
    if (request.type === transactionTypes.INCOME) {
      return (
-        <Typography as="span" fontSize="inherit">
+        <Typography component="div" as="span" fontSize="inherit">


Use rather component="div" or span.

nistadev · 2023-12-11T12:14:17Z

packages/yoroi-extension/app/connector/components/signin/UtxoDetails.js

@@ -176,7 +176,7 @@ class UtxoDetails extends Component<Props> {
            light
            linkType="address"
          >
-            <Typography as="span" color="var(--yoroi-palette-gray-600)">
+            <Typography component="div" as="span" color="var(--yoroi-palette-gray-600)">


Use rather component="div" or span.

nistadev · 2023-12-11T12:15:14Z

packages/yoroi-extension/app/connector/components/signin/cardano/UtxoDetails.js

@@ -157,7 +157,7 @@ class CardanoUtxoDetails extends Component<Props> {
            light
            linkType="address"
          >
-            <Typography as="span" color="#242838">
+            <Typography component="div" as="span" color="#242838">


Use rather component="div" or span.

nistadev · 2023-12-11T12:16:28Z

packages/yoroi-extension/app/containers/wallet/dialogs/RevampAnnouncementDialog.js

@@ -116,7 +116,7 @@ export class RevampAnnouncementDialog extends Component<Props> {
                }}
              >
                {[messages.update1, messages.update2, messages.update3].map(message => (
-                  <Typography component="li" variant="body1" color="grayscale.900">
+                  <Typography component="div" component="li" variant="body1" color="grayscale.900">


Remove component="div" since we have another component defined.

nistadev · 2023-12-11T12:16:34Z

packages/yoroi-extension/app/containers/wallet/dialogs/RevampAnnouncementDialog.js

@@ -130,7 +130,7 @@ export class RevampAnnouncementDialog extends Component<Props> {
                }}
              >
                {[messages.update4, messages.update5, messages.update6].map(message => (
-                  <Typography component="li" variant="body1" color="grayscale.900">
+                  <Typography component="div" component="li" variant="body1" color="grayscale.900">


Remove component="div" since we have another component defined.

yushih · 2023-12-12T16:36:13Z

@nistadev I added component="div" instead of "span" to <Typography that originally were rendered as  because  is a block element. If  is replaced by a  which is an inline element, the layout may be broken.

Nebyt

LGTM

…iminate-warnings # Conflicts: # packages/yoroi-extension/app/components/wallet/send/WalletSendFormRevamp.js # packages/yoroi-extension/app/components/widgets/OpenInExplorer.js # packages/yoroi-extension/app/connector/components/signin/AddCollateralPage.js # packages/yoroi-extension/app/connector/components/signin/CardanoSignTxPage.js # packages/yoroi-extension/app/connector/components/signin/SignTxPage.js # packages/yoroi-extension/app/connector/components/signin/UtxoDetails.js # packages/yoroi-extension/app/connector/components/signin/cardano/ConnectionInfo.js # packages/yoroi-extension/app/connector/components/signin/cardano/SignTx.js # packages/yoroi-extension/app/connector/components/signin/cardano/SignTxSummary.js

vsubhuman

/check

vsubhuman

/check

vsubhuman

/check

sonarqube-yoroi · 2023-12-15T16:53:17Z

SonarQube Quality Gate

0 Bugs
0 Vulnerabilities
0 Security Hotspots
6 Code Smells

No Coverage information
0.0% Duplication

yushih added 3 commits December 8, 2023 19:32

get rid of 

8a2c01e

remove undefined property

2749191

always pass string to to property of Link

8d306e4

Merge branch 'develop' into chore/YOEXT-940/eliminate-warnings

81beac8

vsubhuman added this to the 5.1.0 (swap, dynamic params) milestone Dec 11, 2023

Nebyt requested a review from nistadev December 11, 2023 11:15

nistadev requested changes Dec 11, 2023

View reviewed changes

yushih added 3 commits December 11, 2023 21:08

remove wrong component

3b90581

remove component="div" for components with as="..."

2e73298

fix

d3bea46

yushih requested a review from nistadev December 12, 2023 16:36

yushih and others added 3 commits December 13, 2023 01:01

fix

0ac0aed

Merge branch 'develop' into chore/YOEXT-940/eliminate-warnings

8d99f31

Merge branch 'develop' into chore/YOEXT-940/eliminate-warnings

6340f7d

Nebyt previously approved these changes Dec 14, 2023

View reviewed changes

vsubhuman added 2 commits December 15, 2023 00:50

lint fix

0ef3ab3

vsubhuman dismissed Nebyt’s stale review via 0ef3ab3 December 14, 2023 21:56

vsubhuman reviewed Dec 14, 2023

View reviewed changes

disable lint react/jsx-first-prop-new-line rule

c5bda74

vsubhuman reviewed Dec 14, 2023

View reviewed changes

vsubhuman added 2 commits December 15, 2023 14:09

Merge branch 'develop' into chore/YOEXT-940/eliminate-warnings

72a2f18

removing duplicate properties

2f153d5

vsubhuman reviewed Dec 15, 2023

View reviewed changes

lint auto fix

13d878e

vsubhuman merged commit 6f9f5a3 into develop Dec 15, 2023
3 checks passed

vsubhuman deleted the chore/YOEXT-940/eliminate-warnings branch December 15, 2023 16:54

vsubhuman mentioned this pull request Jan 22, 2024

Release / 5.1.0 #3395

Merged

24 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Chore/yoext 940/eliminate warnings #3365

Chore/yoext 940/eliminate warnings #3365

yushih commented Dec 11, 2023

neuodev commented Dec 11, 2023

nistadev left a comment

nistadev Dec 11, 2023

nistadev Dec 11, 2023

nistadev Dec 11, 2023

nistadev Dec 11, 2023

nistadev Dec 11, 2023

nistadev Dec 11, 2023

nistadev Dec 11, 2023

nistadev Dec 11, 2023

nistadev Dec 11, 2023

nistadev Dec 11, 2023

yushih commented Dec 12, 2023

Nebyt left a comment

vsubhuman left a comment

vsubhuman left a comment

vsubhuman left a comment

sonarqube-yoroi bot commented Dec 15, 2023

Chore/yoext 940/eliminate warnings #3365

Chore/yoext 940/eliminate warnings #3365

Conversation

yushih commented Dec 11, 2023

neuodev commented Dec 11, 2023

nistadev left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

yushih commented Dec 12, 2023

Nebyt left a comment

Choose a reason for hiding this comment

vsubhuman left a comment

Choose a reason for hiding this comment

vsubhuman left a comment

Choose a reason for hiding this comment

vsubhuman left a comment

Choose a reason for hiding this comment

sonarqube-yoroi bot commented Dec 15, 2023