Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature(notice): analytics consent notice #2573

Merged

Conversation

jorbuedo
Copy link
Contributor

@jorbuedo jorbuedo commented Aug 2, 2023

Ticket: https://emurgo.atlassian.net/browse/YOMO-659

Adds the consent notice for analytics. Using a Modal for now, once BottomSheet is merged in it can be easily changed.

image

@jorbuedo jorbuedo self-assigned this Aug 2, 2023
@jorbuedo jorbuedo changed the title Adds analytics notice to optin feature(notice): analytics consent notice Aug 2, 2023
@stackchain stackchain added this to the 4.20.0 milestone Aug 2, 2023
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we have the story with consent open?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is open on storybook, but I'm not 100% sure how the mocked storage is dealing with it.

@stackchain stackchain merged commit 7c6c8d1 into yomo-657-analytics-warning Aug 2, 2023
@stackchain stackchain deleted the yomo-659-analytics-notification branch August 2, 2023 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants