chore(tests): E2e html reporter #2585
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
rahulnr7
commented
Aug 3, 2023
rahulnr7
commented
- Add html reporter for e2e test results
- Add utils to take and attach screenshots
- Handle the insights screen
michaeljscript
approved these changes
Aug 3, 2023
| @@ -0,0 +1,5 @@ | |||
| import {by, element} from 'detox' | |||
|
|
|||
| export const btn_Skip = () => element(by.label('SKIP')) | |||
There was a problem hiding this comment.
could we use camelCase here?
There was a problem hiding this comment.
@MichalSzorad this is a practice I follow to indicate the type of the locator (btn for button, lnk for link etc..). But I have been getting review comments all the time for following the camelCase :) . I will make changes in the next PR. Thanks for your review!
Nebyt
approved these changes
Aug 3, 2023
stackchain
force-pushed
the
e2e-html-reporter
branch
from
c7bf9c5 to
d7f0b6d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.