Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(swap): Remove verified filter, API returns only verified ones #2681

Merged
merged 4 commits into from
Sep 15, 2023
Merged

fix(swap): Remove verified filter, API returns only verified ones #2681

merged 4 commits into from
Sep 15, 2023

Conversation

jorbuedo
Copy link
Contributor

@jorbuedo jorbuedo requested a review from SorinC6 September 12, 2023 15:22
@jorbuedo jorbuedo self-assigned this Sep 12, 2023
SorinC6
SorinC6 approved these changes Sep 13, 2023
View reviewed changes
Copy link
Contributor

@SorinC6 SorinC6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jorbuedo have you checked with product related to removing it? maybe if they will want to show it later we can just hide it until adding our own filters as well 🤔

@jorbuedo jorbuedo marked this pull request as ready for review September 13, 2023 08:46
@jorbuedo
Copy link
Contributor Author

@jorbuedo have you checked with product related to removing it? maybe if they will want to show it later we can just hide it until adding our own filters as well 🤔

Waiting for answer

@jorbuedo jorbuedo changed the title Remove implicit verify filter fix(swap): Remove verified filter, API returns only verified ones Sep 13, 2023
@jorbuedo jorbuedo requested a review from stackchain September 13, 2023 08:48
@jorbuedo
Copy link
Contributor Author

Looks like no one knows and it's gonna take a while, so I'm adding the verified filter to the list just in case the API changes suddenly again to include unverified ones. But assume that's not gonna be the case, so no UI switch to toggle.

@stackchain
Copy link
Member

stackchain commented Sep 15, 2023 •
edited
Loading

in-fact is returning only verified, if they changed it later, we can revert the commit

@stackchain stackchain added this to the 5.0.0 milestone Sep 15, 2023
@stackchain stackchain merged commit 9b156dc into develop Sep 15, 2023
@stackchain stackchain deleted the yomo-759 branch September 15, 2023 09:17
@stackchain stackchain mentioned this pull request Oct 23, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SorinC6 SorinC6 SorinC6 approved these changes

@stackchain stackchain Awaiting requested review from stackchain

Assignees

@jorbuedo jorbuedo

Labels
fix
Projects
None yet
Milestone
4.23.0
Development

Successfully merging this pull request may close these issues.
3 participants
@jorbuedo @stackchain @SorinC6