feat(swap): Allow cancellation of an open order #2683
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stackchain
reviewed
Sep 27, 2023
michaeljscript
commented
Sep 27, 2023
stackchain
reviewed
Sep 28, 2023
stackchain
reviewed
Sep 28, 2023
lisicky
reviewed
Sep 28, 2023
stackchain
reviewed
Sep 28, 2023
apps/wallet-mobile/src/yoroi-wallets/cardano/shelley/signatureUtils.ts
Outdated
Show resolved
Hide resolved
stackchain
reviewed
Sep 28, 2023
stackchain
reviewed
Sep 28, 2023
...-mobile/src/features/Swap/common/ConfirmWithSpendingPassword/ConfirmWithSpendingPassword.tsx
Outdated
Show resolved
Hide resolved
lisicky
reviewed
Sep 28, 2023
apps/wallet-mobile/src/features/Swap/useCases/StartSwapScreen/ListOrders/helpers.ts
Show resolved
Hide resolved
lisicky
reviewed
Sep 29, 2023
| return CardanoMobile.TransactionBuilder.new(assertRequired(txBuilderCfg, 'Could not build transaction builder')) | ||
| } | ||
|
|
||
| const operations1 = Object.values({ |
There was a problem hiding this comment.
I would move it in separate file with all protocol params
lisicky
reviewed
Sep 29, 2023
| return value | ||
| } | ||
|
|
||
| export const fixScriptHash = async (tx: CSL_TYPES.Transaction) => { |
There was a problem hiding this comment.
You can recalculate script hash without building tx by tx builder. There is function hash_script_data that you can use
lisicky
approved these changes
Sep 29, 2023
| import {CardanoMobile} from '../../wallets' | ||
|
|
||
| export const signRawTransaction = async (txHex: string, pKeys: PrivateKey[]): Promise<Uint8Array> => { | ||
| const fixedTx = await CardanoMobile.FixedTransaction.fromHex(txHex) |
There was a problem hiding this comment.
it you have byte array you can call fromBytes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves YOMO-750
Note this PR does not have HW wallet support yet.