New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixes(swap) fees calculation, slippage error, market price #2694

Merged

stackchain merged 14 commits into develop from swap-fixes

Sep 21, 2023

Contributor

SorinC6 commented Sep 19, 2023 •

edited

Loading

task:

add total fees calculation
reset market price when refresh swap
add info modal for pool actions card
move helpers in swap package
https://emurgo.atlassian.net/browse/YOMO-786
https://emurgo.atlassian.net/browse/YOMO-793
https://emurgo.atlassian.net/browse/YOMO-794


          fix fees calculation, slippage error, market price

96748ae

SorinC6 marked this pull request as draft

September 19, 2023 09:49

SorinC6 added the in-progress label

SorinC6 added 10 commits

September 19, 2023 14:29


          metada

bf08cec


          add more metadata when creating the unsignedTX

091c585


          add functions in swap modules

2493ab6


          fix naming

846aa6f


          fix tests


          add missing test

3390abe


          add more tests coverage

e595e8c


          add helpers from swap modules

f5fd975


          remove unused imports

f590a11


          remove spacer

396ddf9

stackchain reviewed

View reviewed changes

apps/wallet-mobile/src/features/Swap/useCases/ConfirmTxScreen/TransactionSummary.tsx Outdated Show resolved Hide resolved

stackchain reviewed

View reviewed changes

apps/wallet-mobile/src/features/Swap/useCases/StartSwapScreen/CreateOrder/CreateOrder.tsx Outdated Show resolved Hide resolved

stackchain reviewed

View reviewed changes

apps/wallet-mobile/src/features/Swap/useCases/StartSwapScreen/CreateOrder/EditLimitPrice.tsx Show resolved Hide resolved

stackchain reviewed

View reviewed changes

...t-mobile/src/features/Swap/useCases/StartSwapScreen/CreateOrder/EditPool/ShowPoolActions.tsx Outdated Show resolved Hide resolved

stackchain reviewed

View reviewed changes

.../src/features/Swap/useCases/StartSwapScreen/CreateOrder/ShowTokenActions/TopTokenActions.tsx Show resolved Hide resolved

stackchain reviewed

View reviewed changes

packages/swap/src/helpers/orders/getMinAdaReceiveAfterSlippage.ts Show resolved Hide resolved

stackchain reviewed

View reviewed changes

packages/swap/src/helpers/orders/getMinAdaReceiveAfterSlippage.test.ts Outdated Show resolved Hide resolved

stackchain reviewed

View reviewed changes

packages/swap/src/helpers/orders/getTotalFees.test.ts Outdated Show resolved Hide resolved

stackchain reviewed

View reviewed changes

packages/swap/src/helpers/orders/getTotalFees.test.ts Outdated Show resolved Hide resolved

stackchain reviewed

View reviewed changes

packages/swap/src/helpers/orders/getTotalFees.ts Outdated Show resolved Hide resolved

stackchain reviewed

View reviewed changes

packages/types/src/helpers/types.ts Outdated Show resolved Hide resolved

SorinC6 added 3 commits

September 20, 2023 11:24


          fix: remove hardcoded ada value

5140a1b


          fix: use capitalize from lodash

ef826c5


          move types

27006a2

SorinC6 marked this pull request as ready for review

September 20, 2023 12:49

SorinC6 removed the in-progress label

stackchain approved these changes

View reviewed changes

stackchain merged commit 81f8582 into develop

stackchain deleted the swap-fixes branch

September 21, 2023 10:36

stackchain added this to the 5.0.0 milestone

stackchain added fix refactor labels

stackchain mentioned this pull request

release: version 4.23.0-rc.9 #2821

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels