Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: bottomsheet modal #2699

Merged
merged 6 commits into from
Sep 21, 2023
Merged

refactor: bottomsheet modal #2699

merged 6 commits into from
Sep 21, 2023

Conversation

banklesss
Copy link
Contributor

@banklesss banklesss commented Sep 21, 2023

WAITING PRODUCT FEEDBACK

Related to YOMO-758 and YOMO-777

storybook.mov

Currently only implemented in the swap confirm tx screen:

confirmtx.mov

Co-authored-by: Juliano Lazzarotto <30806844+stackchain@users.noreply.github.com>
Signed-off-by: banklesss <105349292+banklesss@users.noreply.github.com>
…ConfirmTxScreen.tsx

Co-authored-by: Juliano Lazzarotto <30806844+stackchain@users.noreply.github.com>
Signed-off-by: banklesss <105349292+banklesss@users.noreply.github.com>
Copy link
Member

@stackchain stackchain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@banklesss banklesss marked this pull request as ready for review September 21, 2023 09:43
@stackchain stackchain merged commit a4cfba9 into develop Sep 21, 2023
@stackchain stackchain deleted the refactor/bottomsheet-modal branch February 6, 2024 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants