feature: collateral settings/manager #2703
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
stackchain
commented
Sep 24, 2023
•
stackchain
commented
- add collateral to utxos manager
- set initial state to load collateral
- remove collateral from other utxos when set (affects balance)
- auto assign a pure utxo as collateral
- create a tx to create the collateral
- remove selected collateral
- check copies with product
- check suggested layout with product
- check states (with collateral, with collateral consumed, without collateral)
- check state - no balance for collateral (tx creation, balance - deposit >= min collateral)
- check collateral range 5-10 ADA with product (defined 2-5 ADA)
- the yoroi-lib is complaining when sending to own external (missing vkey)
- between the dispatch of unsingedTx and navigation it needs a little delay, the state is not committed when navigating to confirmTx (unsingedTx is empty)
- wrap collateral stories within SendProvider (added later)
- translations
stackchain
commented
Sep 25, 2023
apps/wallet-mobile/src/yoroi-wallets/cardano/utxoManager/utxos.ts
Outdated
Show resolved
Hide resolved
stackchain
commented
Sep 25, 2023
apps/wallet-mobile/src/features/Settings/ManageCollateral/ManageCollateralScreen.stories.tsx
Show resolved
Hide resolved
…into feature/collateral
| }, | ||
| ) | ||
|
|
||
| const {isLoading: isLoadingCollateral, setCollateralId} = useSetCollateralId(wallet) |
There was a problem hiding this comment.
Is there any way we can call setCollateralId right after we submit the TX? If not, do we have to navigate back to this screen and click "generate collateral" again?
There was a problem hiding this comment.
Should setCollateralId(`${signedTx.signedTx.id}:0`); in onSuccess in ConfirmTxScreen work? I don't quite like the index is hardcoded
There was a problem hiding this comment.
can you read the outputs of the unsigned tx?
There was a problem hiding this comment.
let's create task for these 3 remaining items
There was a problem hiding this comment.
Hello @stackchain 3 remaining items, you mean the following?
- setCollateralId after tx is completed
- check copies with product
- check suggested layout with product
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.