chore: Swap/UI updates #2760
Merged
chore: Swap/UI updates #2760
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SorinC6
requested review from
banklesss,
michaeljscript,
jorbuedo and
stackchain
banklesss
reviewed
Oct 13, 2023
| result['metadata'] = metadata | ||
| return acc.concat(result as MappedRawOrder) | ||
| } catch (error) { | ||
| console.warn('Error parsing json metadata', error) |
There was a problem hiding this comment.
would an alert be ok here?
michaeljscript
approved these changes
Oct 13, 2023
jorbuedo
reviewed
Oct 13, 2023
| @@ -122,7 +134,8 @@ export const ExpandableOrder = ({order}: {order: MappedRawOrder}) => { | |||
| const buyQuantity = Quantities.format(metadata.buyQuantity as Balance.Quantity, buyTokenInfo.decimals ?? 0) | |||
| const sellQuantity = Quantities.format(metadata.sellQuantity as Balance.Quantity, sellTokenInfo.decimals ?? 0) | |||
| const tokenPrice = asQuantity(new BigNumber(metadata.sellQuantity).dividedBy(metadata.buyQuantity).toString()) | |||
| const marketPrice = Quantities.format(tokenPrice, sellTokenInfo.decimals ?? 0, MAX_DECIMALS) | |||
| const denomination = (sellTokenInfo.decimals ?? 0) - (buyTokenInfo.decimals ?? 0) | |||
| const marketPrice = Quantities.format(tokenPrice ?? Quantities.zero, denomination, PRECISION) | |||
There was a problem hiding this comment.
This is gonna have to be abstracted if we keep using it in more places.
jorbuedo
approved these changes
Oct 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tasks:
Complete ordertab