refactor: token list api source #2860
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stackchain
requested review from
SorinC6,
banklesss,
jorbuedo and
michaeljscript
stackchain
force-pushed
the
refactor/token-list-source
branch
from
6834a1f to
573a422
Compare
stackchain
commented
Nov 1, 2023
| @@ -63,13 +62,15 @@ export const AmountItem = ({isPrivacyOff, wallet, style, amount, inWallet, suppl | |||
| </Middle> | |||
|
|
|||
| <Right> | |||
| {tokenInfo.kind !== 'nft' && ( | |||
| {tokenInfo.kind !== 'nft' && variant !== 'swap' && ( | |||
There was a problem hiding this comment.
changed the variant swap to don't list supply / pair
stackchain
commented
Nov 1, 2023
| const isValidNameB = containsOnlyValidChars(b.info.name) | ||
| const isValidTickerA = containsOnlyValidChars(a.info.ticker) | ||
| const isValidTickerB = containsOnlyValidChars(b.info.ticker) | ||
| export const sortTokensByName = (a: Balance.TokenInfo, b: Balance.TokenInfo, wallet: YoroiWallet) => { |
There was a problem hiding this comment.
new endpoint returns TokenInfo not Token, adjusted
stackchain
commented
Nov 1, 2023
| "version": "independent", | ||
| "command": { | ||
| "run": { | ||
| "ignore": ["e2e/*"] |
There was a problem hiding this comment.
ignoring e2e on lerna (it was rebuilding it)
stackchain
commented
Nov 1, 2023
| @@ -95,13 +96,17 @@ export class OpenSwapApi { | |||
| ) | |||
| } | |||
|
|
|||
| public async getTokens({policyId = '', assetName = ''} = {}) { | |||
| const tokens = await getTokens( | |||
| public async getTokenPairs({policyId = '', assetName = ''} = {}) { | |||
There was a problem hiding this comment.
getTokens is actually getTokenPairs
stackchain
commented
Nov 1, 2023
| ticker: info.symbol, | ||
| metadatas: {}, | ||
| }, | ||
| info: asYoroiBalanceTokenInfo(info), |
There was a problem hiding this comment.
migrated to the specialized helper
stackchain
commented
Nov 1, 2023
| @@ -57,7 +57,7 @@ export const SwapTabNavigator = () => { | |||
| }, [aggregatorTokenId, lpTokenHeld, lpTokenHeldChanged]) | |||
|
|
|||
| // pre load swap tokens | |||
| const {refetch} = useSwapTokensByPairToken('', {suspense: false, enabled: false}) | |||
| const {refetch} = useSwapTokensOnlyVerified({suspense: false, enabled: false}) | |||
There was a problem hiding this comment.
pre-fetch updated, until we migrate router for tan stack router
michaeljscript
approved these changes
Nov 1, 2023
banklesss
approved these changes
Nov 1, 2023
stackchain
force-pushed
the
refactor/token-list-source
branch
from
573a422 to
8e0c66d
Compare
SorinC6
approved these changes
Nov 1, 2023
jorbuedo
approved these changes
Nov 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
** Breaking change **
Relates to YOMO-925
Context
The
/listapi is very restricted to the amount of queries 1/hour