-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature(wallet-mobile): prefetch ada prices #3663
Conversation
apps/wallet-mobile/src/features/Portfolio/common/PortfolioProvider.tsx
Outdated
Show resolved
Hide resolved
apps/wallet-mobile/src/features/Portfolio/common/hooks/useGetPortfolioTokenChart.ts
Outdated
Show resolved
Hide resolved
apps/wallet-mobile/src/features/Portfolio/common/hooks/useGetPortfolioTokenChart.ts
Show resolved
Hide resolved
@stackchain This contains 2 things:
Is it the method to check for the endpoint being live that you don't like? |
On top of my head, when the feature is actually active for all tokens, for those tokens without data the behaviour would be same, so I believe there is no need for this implementation, yet needs confirmation. |
Oh I agree, but it's something product asked for specifically because they wanted to hide the section until the API was ready. |
@@ -21,7 +21,7 @@ export const TokenChartToolbar = ({timeInterval, disabled, onChange}: Props) => | |||
|
|||
return ( | |||
<View style={styles.chartToolbar}> | |||
{Object.values(TOKEN_CHART_INTERVAL).map((itv) => ( | |||
{Object.values(TokenChartInterval).map((itv) => ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it is missing translations it'd show 24 H
, 1 W
for all languages.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the interval label from TokenPerformance maybe should be moved to useStrings
🤷🏻
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mm yeah, that was never translated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
create a task please
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lg, just 1 point regarding translations, I think only he chart label is affected cc: @jorbuedo
Description / Change(s) / Related issue(s)
Ticket
https://emurgo.atlassian.net/browse/YOMO-1943