Ft/creating-dynamic-navbar #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kareraolivier
added
documentation
AdelineA
reviewed
Mar 19, 2024
src/components/header/index.tsx
Outdated
Comment on lines
30
to
35
| <Image | ||
| src="./images/smallArrow.png" | ||
| alt="arrow" | ||
| width={100} | ||
| height={100} | ||
| /> |
There was a problem hiding this comment.
I would suggest using the svg for arrows instead of using images.
src/components/header/index.tsx
Outdated
Comment on lines
44
to
49
| <Image | ||
| src="./images/smallArrow.png" | ||
| alt="arrow" | ||
| width={100} | ||
| height={100} | ||
| /> |
src/components/header/index.tsx
Outdated
Comment on lines
51
to
56
| <Image | ||
| src="./images/smallArrow.png" | ||
| alt="arrow" | ||
| width={100} | ||
| height={100} | ||
| /> |
AdelineA
added
reviewed
NNesta
requested changes
Mar 19, 2024
src/components/header/NavLink.tsx
Outdated
| link: "/case-studies-and-core-tools", | ||
| title: "Level of Co-Design Practice", | ||
| }, | ||
| ]; |
There was a problem hiding this comment.
Can you put this file in utils folder and give it .ts extension as it is not a tsx file
next.config.js
Outdated
| @@ -4,6 +4,9 @@ | |||
| const nextConfig = { | |||
| reactStrictMode: false, | |||
| output: "export", | |||
| images: { | |||
| unoptimized: true, | |||
| }, | |||
There was a problem hiding this comment.
we need to disable optimization becouse we added output:"export", we can't run project local if we do not disable it.
and we need output:"export" so that we can build the project for gitpages
|
|
||
| const HorzontalArrow = () => { | ||
| return ( | ||
| <div> |
There was a problem hiding this comment.
This div is not needed here
kareraolivier
force-pushed
the
ft/creating-dynamic-navbar
branch
2 times, most recently
from
6f1491f to
1d4d644
Compare
kareraolivier
force-pushed
the
ft/creating-dynamic-navbar
branch
from
1d4d644 to
7d6b6ff
Compare
kareraolivier
force-pushed
the
ft/creating-dynamic-navbar
branch
from
047b24f to
87b1058
Compare
…ess/co-design-FE into ft/creating-dynamic-navbar
kareraolivier
force-pushed
the
ft/creating-dynamic-navbar
branch
from
a3edf4f to
0196030
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
updating the header by making content dynamic