feat: add footer component #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
AdelineA
commented
Apr 18, 2024
AdelineA
commented
- add footer component
NNesta
requested changes
Apr 18, 2024
src/components/footer/data-source.ts
Outdated
| .filter((source) => source && !source.includes("Open Access")) | ||
| .filter((source) => source) as string[]; | ||
|
|
||
| export const uniqueDataSources = Array.from(new Set(dataSources)); |
There was a problem hiding this comment.
Can you change this name of this variable to name that give hint what it hold
src/components/footer/index.tsx
Outdated
| <div | ||
| key={index} | ||
| className="flex gap-5 w-full justify-center items-center" | ||
| > |
There was a problem hiding this comment.
Can you align the content to the right side as on the design
musayann
requested changes
Apr 24, 2024
| @@ -0,0 +1,9 @@ | |||
| import output from "../../../public/data.json"; | |||
|
|
|||
| const dataResources = output | |||
There was a problem hiding this comment.
these should be in the src/data folder
NNesta
requested changes
Apr 24, 2024
src/data/footer/index.tsx
Outdated
| import { getColorByAccess } from "../../utils/helpers"; | ||
| import { filteredResources } from "./data-resources"; | ||
|
|
||
| const Footer = () => { |
There was a problem hiding this comment.
Can you put this component inside components folder
musayann
approved these changes
Apr 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.