-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Blacklist helper #9
base: main
Are you sure you want to change the base?
Conversation
specifically for updating blacklists may require some tweaks after integration with the main script
added corresponding features for blacklist edit window
As a heads up I'm going to be really delayed in responding for the next couple of weeks. Will check this as soon as I can. |
Co-authored-by: Encho <38841444+Enchoseon@users.noreply.github.com>
First run on a fresh install in a new browser in Violentmonkey 2.14.0 on Firefox 114.0.1, got this error:
Crashes the entire script. Here's the snippet the error points to: resources/gelbooru-overhaul.blacklistManager.js
221- let nameList = document.createElement("datalist");
222- nameList.setAttribute("id", "go-advBlacklistListNames");
223: scope.blacklistItems.forEach(i => { Still don't have time to look onto it properly, but posting this here for proper bookkeeping. |
Looks like 'scope' is undefined. I'll try replace it with my recent discovery 'this.func = this.func.bind(this) when I get my hands on the code. |
fixed blacklistItems is undefined fixed error on applying OrderEntriesByHitCount while manager is not set up
I just forgot to declare 'blacklistItems' in the class. Actually I got a different error but I believe this should fix it. |
Feel free to double-check it.
It works not as good as I expected with a few minutes of resource update delay but still better than copying in manually.
Ping me if docs need more explanation.
As the next step I would like to make some cleanup and then document all modules (maybe with some fancy 'jsdoc to md' github actions)