use keyword-only params in sort_index #188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
in methods where inplace is allowed, non-keyword args will become deprecated soon: pandas-dev/pandas#41506 This does not change any current behavior, but removes a deprecation warning when using the latest pandas version
|
hi @maurerle thank you, is that really the only place where this is a problem? |
|
I heavily used this library in the past days with python 3.10 and latest pandas and this was the only occurence where I saw the DeprecationWarning from pandas. One could also directly remove the usage of inplace to be safe for the next few years - as this is the source of the issue, but for now there are no deprecationwarnings for this. |
|
hi @maurerle thanks then ill merge this! |
fleimgruber
pushed a commit
to fleimgruber/entsoe-py
that referenced
this pull request
May 14, 2024
use keyword-only params in sort_index
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in methods where inplace is allowed, non-keyword args will become deprecated soon:
pandas-dev/pandas#41506
This does not change any current behavior, but removes a deprecation warning when using the latest pandas version