Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect ylabel #11

Merged
merged 1 commit into from
Sep 9, 2024
Merged

Fix incorrect ylabel #11

merged 1 commit into from
Sep 9, 2024

Conversation

Zetison
Copy link
Collaborator

@Zetison Zetison commented Sep 9, 2024

Fix incorrect ylabel when using scale_tot_opex=true. Also included the following enhancements and adjustments

  • Enable collect for ::EnergySystemDesign by providing the function length(::EnergySystemDesign).
  • Update EMI_geography.png image and remove redundant image example.png (as this is generated by docs).
  • Improve performance. Line src/utils_GUI/GUI_utils.jl:252 and src/utils_GUI/GUI_utils.jl:486 still account for over 65% of initialization of the GUI for large cases (i.e., 8760 operational periods with three strategic periods), so further optimization is probably possible.

… following enhancements and adjustments

* Enable collect for ::EnergySystemDesign by providing the function length(::EnergySystemDesign).
* Update EMI_geography.png image and remove redundant image example.png (as this is generated by docs).
* Improve performance. Line src/utils_GUI/GUI_utils.jl:252 and src/utils_GUI/GUI_utils.jl:486 still accounts for over 65% of initialization of the GUI for large problems (i.e., 8760 operational periods with three strategic periods), so futher optimization is probably possible.
@Zetison Zetison added the bug Something isn't working label Sep 9, 2024
@Zetison Zetison requested a review from JulStraus September 9, 2024 06:54
@Zetison Zetison self-assigned this Sep 9, 2024
Copy link
Member

@JulStraus JulStraus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. We can at one point consider replacing the if loop in initialize_available_data! with sub functions using dispatch, but that is not crucial right now.

@Zetison Zetison merged commit 508688b into main Sep 9, 2024
4 checks passed
@Zetison Zetison deleted the bugfix/ylabel branch September 9, 2024 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants