-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
More validation #180
More validation #180
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #180 +/- ##
==========================================
- Coverage 84.96% 84.69% -0.27%
==========================================
Files 12 12
Lines 379 392 +13
==========================================
+ Hits 322 332 +10
- Misses 57 60 +3 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All good, except for some minor stylistic things.
Co-authored-by: Alex Dewar <alexdewar@users.noreply.github.com>
Done! I've not used |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All looks good to me
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome! Thanks 😄
Description
Adds more validation to the process parameters. In addition to what's described in #163, if also validates the lifetime since, presumably, it should be a number greater than zero, and not just positive.
Fixes #163
Type of change
Key checklist
$ cargo test
$ cargo doc
Further checks