Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ts-registry] simplify JPEG single frame decoding #549

Merged
merged 3 commits into from
Aug 13, 2024
Merged

[ts-registry] simplify JPEG single frame decoding #549

merged 3 commits into from
Aug 13, 2024

Conversation

Enet4
Copy link
Owner

@Enet4 Enet4 commented Jul 28, 2024 •
edited
Loading

Resolves #537.

Summary

  • when decoding a single frame with the JPEG adapter, call the decoder only once
  • increase resilience of JPEG decoder by looking for the next SOI marker after each frame decode
  • add test case with more trailing bytes

@Enet4 Enet4 added bug This is a bug A-lib Area: library C-transfer-syntax Crate: dicom-transfer-syntax-registry jpeg Support for the JPEG family of transfer syntaxes labels Jul 28, 2024
@Enet4 Enet4 marked this pull request as ready for review August 6, 2024 18:45
Enet4 added 3 commits August 6, 2024 21:52
@Enet4
[ts-registry] simplify JPEG single frame decoding
19ea8d7 
- only run decode once
- add test case with trailing bytes
@Enet4
[ts-registry] fix detection of frame start when decoding all frames w…
c92d0fa 
…ith JPEG adapter
@Enet4
[toimage] add hidden argument --decode-all
64622d2 
- to test the use of `decode_pixel_data` while
  only grabbing one of the frames
@Enet4 Enet4 force-pushed the bug/ts-registry/jpeg-harden branch from de7803f to 64622d2 Compare August 6, 2024 20:52
@Enet4 Enet4 merged commit 80f5066 into master Aug 13, 2024
4 checks passed
@Enet4 Enet4 deleted the bug/ts-registry/jpeg-harden branch August 13, 2024 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
A-lib Area: library bug This is a bug C-transfer-syntax Crate: dicom-transfer-syntax-registry jpeg Support for the JPEG family of transfer syntaxes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

First two bytes are not an SOI marker
1 participant
@Enet4