Require DICOM times to encode with the given precision even for 0 microseconds #557
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- make no exception for zero microseconds: this does not seem to be DICOM compliant and is inconsistent with the calculated byte length
- Fix typos - Use code formatting for date/time formats - Turn some comments into doc comments
DimitriPapadopoulos
added a commit
to DimitriPapadopoulos/codespell
that referenced
this pull request
Sep 1, 2024
DimitriPapadopoulos
added a commit
to codespell-project/codespell
that referenced
this pull request
Sep 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Intends to resolve #556.
@jmlaka I would greatly appreciate your input on this one, if you can. The previous iteration of
DicomTimemade some assumptions about how the fractions of seconds component should be encoded, namely that if the number of microseconds is zero, it should always be encoded as.0regardless of precision. From the description of VR DT in the standard (PS3.5 section 6.2), I could not find such a requirement. It sounds to me that we are supposed to comply with the precision provided and insert all the trailing zeros accordingly, which is the case when producing a time via chrono.