Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AWS Fix for support list of IPs with All Trafic's rule #70

Merged
merged 1 commit into from
Jul 29, 2020

Conversation

davajdosvidaniya
Copy link
Contributor

  • Issue

#69

  • Desc

In my AWS EC2 Security Group setup exist a number of IP address with All Traffic inbound rules.
So even the host's IP is present in the group still getting the error: Do you need to add your IP to security group... ?

  • Fix

Break the loop only if IP address found / parsedCIDR.Contains(parsedIP) , aka true and continue with check on next address in the list, if exist.

  • Test

Create a group with number of All Traffic rules and verify that logic iterate over all of them.

@crsimmons
Copy link
Contributor

LGTM 👍

Thanks for the PR!

It also doesn't look like the same issue would impact GCP because of how firewalls work there. I'll add some kind of test for this then cut a release.

@crsimmons crsimmons merged commit 1b0dc38 into EngineerBetter:master Jul 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants