[Linux] curl.exe doesn't exist

[FederAndInk]

Modpack Version

none

Describe your issue.

curl.exe won't work on Linux, I think you'll need a variable set to curl.exe on win and to curl on Linux

btw, I think you need to change your issue template for this repo ^^

Crash Report

No response

Latest Log

No response

Have you modified the modpack?

No

User Modifications

No response

Did the issue happen in singleplayer or on a server?

Both

Discord Username

No response

[NielsPilgaard]

Thanks for the report, I'll get that fixed (eventually 😅)

[FederAndInk]

thanks,
I would have done it, but I don't know powershell, I've seen there is $IsWindows $IsLinux variables though.
Python could have been more widespread and Linux friendly :p

[FederAndInk]

Python could have been more widespread and Linux friendly :p

But great project anyways 😄

[NielsPilgaard]

I removed those variables 😓

[FederAndInk]

what do you mean?
shouldn't they be built-in?

[FederAndInk]

this is what I get out of the box:

PS /home/nihil> Write-Host $IsLinux
True
PS /home/nihil> Write-Host $IsWindows
False
PS /home/nihil> Write-Host $IsMacos
False

[NielsPilgaard]

I'm afraid those variables only exist in Powershell Core, not the windows native version, so I can't rely on them :/

[FederAndInk]

well then, you could try to see if the variable is defined and do:

if IsWindows not defined or $IsWindows
  use curl.exe
else
  use curl

[FederAndInk]

found this otherwise: https://devblogs.microsoft.com/scripting/powertip-determine-your-version-of-powershell-and-host-operating-system/

using $PSVersionTable

Scripting Blog

PowerTip: Determine your version of PowerShell and host operating system

Identify your PowerShell environment by making use of built-in PowerShell variables.

[NielsPilgaard]

Should be all fixed, thanks for the helpful pointers :)
Edit: Would you mind checking if the fix actually works? I only have a Windows laptop at my disposal

[FederAndInk]

no problem, thank you for the fix.
btw, isn't possible to store curl or curl.exe in a variable like in bash? and use it as a command

[NielsPilgaard]

Oh, it actually is. That simplifies this greatly.

[NielsPilgaard]

Changed, thanks :D https://github.com/EnigmaticaModpacks/ModpackUploader/releases/tag/2.3.2

GitHub

Release 2.3.2 · EnigmaticaModpacks/ModpackUploader

What's Changed

simplify how the curl command is determined by @NielsPilgaard in #26

Full Changelog: 2.3.0...2.3.2