New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adopt is dead, long live Zulu! #279

Merged

sergehuber merged 1 commit into Enigmatis:master from geertjanw:master

May 26, 2023

Contributor

geertjanw commented Aug 28, 2021

No description provided.


          Adopt is dead, long live Zulu!

0240c0e

Member

yarinvak commented Sep 6, 2021

would appreciate elaboration on your change

Contributor Author

geertjanw commented Sep 6, 2021

Adopt no longer exists. Two options for v2 right now are 'temurin' or 'zulu'. The first one, 'temurin' is new, and doesn't have all the releases, e.g., the Temurin history starts from 8.0.302, 11.0.12, and 16.0.2, while Zulu supports all versions of these releases.

Contributor Author

geertjanw commented Sep 6, 2021

Right now you're testing only on '8', which is not a fixed version, but that is whatever the latest version of '8' is. You're recommended as a best practise to set the latest version of a release, as well as a fixed version, so that when your build breaks and the fixed version is green while the latest version is red, you'll know that the broken build is because of the latest version of the JDK and not because of anything in your own code.

Here's an example:

https://github.com/HdrHistogram/HdrHistogram/blob/master/.github/workflows/maven.yml

Fgerthoffert requested changes

View reviewed changes

Collaborator

Fgerthoffert left a comment

We're helping on project maintenance.

Once the change is done we will merge your PR. Without answer within 2 months, we will close this PR and create a separate one for the update to zulu.

.github/workflows/build.yml

@@ @@ -14,7 +14,7 @@ jobs: @@
                       uses: actions/setup-java@v2
                       with:
                         java-version: '8'
-                        distribution: 'adopt'
+                        distribution: 'zulu'

Collaborator

Fgerthoffert May 5, 2023

Could you also update to zulu in the publish workflow ?

sergehuber merged commit a4c615b into Enigmatis:master

sergehuber mentioned this pull request

Change to zulu #292

Merged

github-merge-queue bot referenced this pull request in camunda/camunda


          deps: Update dependency io.github.graphql-java:graphql-java-annotatio…

8d0d131

…ns to v21 (main) (#18094)

[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
|
[io.github.graphql-java:graphql-java-annotations](https://github.com/graphql-java/graphql-java-annotations)
| `9.1` -> `21.1` |
[![age](https://developer.mend.io/api/mc/badges/age/maven/io.github.graphql-java:graphql-java-annotations/21.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/maven/io.github.graphql-java:graphql-java-annotations/21.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/maven/io.github.graphql-java:graphql-java-annotations/9.1/21.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/maven/io.github.graphql-java:graphql-java-annotations/9.1/21.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

> [!WARNING]
> Some dependencies could not be looked up. Check the Dependency
Dashboard for more information.

---

### Release Notes

<details>
<summary>graphql-java/graphql-java-annotations
(io.github.graphql-java:graphql-java-annotations)</summary>

###
[`v21.1`](https://github.com/Enigmatis/graphql-java-annotations/releases/tag/v21.1)

[Compare
Source](https://github.com/graphql-java/graphql-java-annotations/compare/v9.1...v21.1)

#### What's Changed

- Fix for
[issue#283](https://github.com/issue/graphql-java-annotations/issues/283)
Renamed bundle.bnd to bnd.bnd to generate OSGi Metadata properly by
[@&#8203;sergehuber](https://github.com/sergehuber) in
[https://github.com/Enigmatis/graphql-java-annotations/pull/284](https://github.com/Enigmatis/graphql-java-annotations/pull/284)
- Upgrade graphql-java by
[@&#8203;manikandan-ravikumar](https://github.com/manikandan-ravikumar)
in
[https://github.com/Enigmatis/graphql-java-annotations/pull/287](https://github.com/Enigmatis/graphql-java-annotations/pull/287)
- Let ID be every type, since it is allowed by by
[@&#8203;EugenMayer](https://github.com/EugenMayer) in
[https://github.com/Enigmatis/graphql-java-annotations/pull/289](https://github.com/Enigmatis/graphql-java-annotations/pull/289)
- Adopt is dead, long live Zulu! by
[@&#8203;geertjanw](https://github.com/geertjanw) in
[https://github.com/Enigmatis/graphql-java-annotations/pull/279](https://github.com/Enigmatis/graphql-java-annotations/pull/279)
- Change to zulu by
[@&#8203;sergehuber](https://github.com/sergehuber) in
[https://github.com/Enigmatis/graphql-java-annotations/pull/292](https://github.com/Enigmatis/graphql-java-annotations/pull/292)
- Bump version graphql-java from 17.2 to 20.3 by
[@&#8203;anatol-sialitski](https://github.com/anatol-sialitski) in
[https://github.com/Enigmatis/graphql-java-annotations/pull/291](https://github.com/Enigmatis/graphql-java-annotations/pull/291)
- Upgrade to GraphQL-Java 21 & Gradle 8.3 by
[@&#8203;sergehuber](https://github.com/sergehuber) in
[https://github.com/Enigmatis/graphql-java-annotations/pull/295](https://github.com/Enigmatis/graphql-java-annotations/pull/295)
- Add Gradle Wrapper Validator to build job, fix build job by
[@&#8203;BlasiusSecundus](https://github.com/BlasiusSecundus) in
[https://github.com/Enigmatis/graphql-java-annotations/pull/293](https://github.com/Enigmatis/graphql-java-annotations/pull/293)
- Add Bnd instructions by
[@&#8203;geichelberger](https://github.com/geichelberger) in
[https://github.com/Enigmatis/graphql-java-annotations/pull/294](https://github.com/Enigmatis/graphql-java-annotations/pull/294)
- Use version 21.1 by [@&#8203;tdraier](https://github.com/tdraier) in
[https://github.com/Enigmatis/graphql-java-annotations/pull/296](https://github.com/Enigmatis/graphql-java-annotations/pull/296)

#### New Contributors

-
[@&#8203;manikandan-ravikumar](https://github.com/manikandan-ravikumar)
made their first contribution in
[https://github.com/Enigmatis/graphql-java-annotations/pull/287](https://github.com/Enigmatis/graphql-java-annotations/pull/287)
- [@&#8203;EugenMayer](https://github.com/EugenMayer) made their first
contribution in
[https://github.com/Enigmatis/graphql-java-annotations/pull/289](https://github.com/Enigmatis/graphql-java-annotations/pull/289)
- [@&#8203;geertjanw](https://github.com/geertjanw) made their first
contribution in
[https://github.com/Enigmatis/graphql-java-annotations/pull/279](https://github.com/Enigmatis/graphql-java-annotations/pull/279)
- [@&#8203;anatol-sialitski](https://github.com/anatol-sialitski) made
their first contribution in
[https://github.com/Enigmatis/graphql-java-annotations/pull/291](https://github.com/Enigmatis/graphql-java-annotations/pull/291)
- [@&#8203;BlasiusSecundus](https://github.com/BlasiusSecundus) made
their first contribution in
[https://github.com/Enigmatis/graphql-java-annotations/pull/293](https://github.com/Enigmatis/graphql-java-annotations/pull/293)
- [@&#8203;geichelberger](https://github.com/geichelberger) made their
first contribution in
[https://github.com/Enigmatis/graphql-java-annotations/pull/294](https://github.com/Enigmatis/graphql-java-annotations/pull/294)

**Full Changelog**:
Enigmatis/graphql-java-annotations@v9.1...v21.1

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/camunda/zeebe).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zMjEuMiIsInVwZGF0ZWRJblZlciI6IjM3LjMyMS4yIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJhdXRvbWVyZ2UiXX0=-->

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet