This repository has been archived by the owner on Feb 1, 2025. It is now read-only.
BVH acceleration and other modifications #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raven-sera
reviewed
Apr 11, 2023
There was a problem hiding this comment.
Note that a git ignore file should be added in asset/ti_tests/
raven-sera
reviewed
Apr 11, 2023
There was a problem hiding this comment.
This should be implemented in the future
|
Merging pull request and releasing v1.2.1 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Marching towards v1.2.1, where we have our first BVH acceleration structure which is capable of accelerating ray intersection by reducing the amount of primitives to be taken into account. Test showed that, for
bunnyscene which contains 14916 triangles, it only takes 30 ms to build BVH tree while achieving roughly 50x speed up compared to the brute force ray intersection which can only prune unnecessary computation via object bounding box. The implementation of BVH tree is done in C++ and I expose a python API via pybind/pybind11. All it takes is to build the bvh code and install locally with minimal effort.Other modifications include:
transient_litmode, the problem of which can be found in issue Transient lit mode output is strange #9