-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Maintenance transfer #42
Comments
Hey @rzr, thanks for opening this issue, I do appreciate the rigor and consideration. Why don't I make you a collaborator on the project now, and we can decide on when/how to publish the npm module later. I'll stick around to make sure no blatantly harmful code makes it through. |
Ok this is nice from you, myself I have some changes in: But if you plan to keep the repo active, that would be even better. Now let's listen for feedback for other potential co-maintainers. And let's close it once it's updated on npm, if you still plan to "npm publish" it. |
Not related but I just noticed that there is a derived project from @djdeath : https://github.com/djdeath/pwm could it been merged back to main project to provide full abstraction of sysfs for I/O ? |
This is dope, thanks for sharing! I didn't realize PWM is supported via sysfs. Seems like the last commit was 5 years ago, but @djdeath let us know if you have any interest in merging back to this project. |
Hey! |
@djdeath sounds great, ty! |
This is merging back Lionel Landwerlin aka @djdeath fork: https://github.com/djdeath/pwm Not yet tested, ARTIK710 has a pwm chip, not RPi. Change-Id: I237a04669c23478a0a32a76623cec7cdd285bc94 Relate-to: EnotionZ#42 Signed-off-by: Philippe Coval <p.coval@samsung.com>
This is merging back Lionel Landwerlin aka @djdeath fork: https://github.com/djdeath/pwm Not yet tested, ARTIK710 has a pwm chip, not RPi. Change-Id: I237a04669c23478a0a32a76623cec7cdd285bc94 Relate-to: EnotionZ#42 Signed-off-by: Philippe Coval <p.coval@samsung.com>
@rzr Feel free to pull that in. Can you wait a day or two? I'm cleaning up the file right now to adhere to modern code style standards, just wanna avoid bumping into large conflicts. |
I think this issue is more-or-less resolved and we've created new PR/issues from this discussion. Closing issue. |
Let me quote @EnotionZ from:
#39
"I'm happy to make someone else maintainer if anyone's interested."
I could volunteer for this, and suggest a cooperative maintenance model (for updating npm repo),
but I am new to project ( #41 )
so if anyone has more experience on this module let us know your plans here,
then @EnotionZ will decide how and when a new version could be released by new maintainers.
My 2c.
The text was updated successfully, but these errors were encountered: