Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maintenance transfer #42

Closed
rzr opened this issue Jul 5, 2018 · 9 comments
Closed

Maintenance transfer #42

rzr opened this issue Jul 5, 2018 · 9 comments

Comments

@rzr
Copy link
Collaborator

rzr commented Jul 5, 2018

Let me quote @EnotionZ from:
#39

"I'm happy to make someone else maintainer if anyone's interested."

I could volunteer for this, and suggest a cooperative maintenance model (for updating npm repo),
but I am new to project ( #41 )
so if anyone has more experience on this module let us know your plans here,
then @EnotionZ will decide how and when a new version could be released by new maintainers.

My 2c.

@EnotionZ
Copy link
Owner

Hey @rzr, thanks for opening this issue, I do appreciate the rigor and consideration. Why don't I make you a collaborator on the project now, and we can decide on when/how to publish the npm module later. I'll stick around to make sure no blatantly harmful code makes it through.

@rzr
Copy link
Collaborator Author

rzr commented Jul 10, 2018

Ok this is nice from you, myself I have some changes in:
https://github.com/TizenTeam/GpiO

But if you plan to keep the repo active, that would be even better.

Now let's listen for feedback for other potential co-maintainers.

And let's close it once it's updated on npm, if you still plan to "npm publish" it.

@rzr
Copy link
Collaborator Author

rzr commented Sep 25, 2018

Not related but I just noticed that there is a derived project from @djdeath :

https://github.com/djdeath/pwm

could it been merged back to main project to provide full abstraction of sysfs for I/O ?
ADC support is also welcome.

@EnotionZ
Copy link
Owner

This is dope, thanks for sharing! I didn't realize PWM is supported via sysfs. Seems like the last commit was 5 years ago, but @djdeath let us know if you have any interest in merging back to this project.

@djdeath
Copy link

djdeath commented Sep 27, 2018

Hey!
Actually I can't really remember why I created that repo :|
I don't think I'll pursue merging this stuff in your project, but feel free to copy anything you think is interesting.

@EnotionZ
Copy link
Owner

@djdeath sounds great, ty!

@rzr
Copy link
Collaborator Author

rzr commented Sep 27, 2018

@EnotionZ I just pushed trivial changes without review to master branch, I can try to merge @djdeath code unless someone else what to do it.

rzr added a commit to TizenTeam/GpiO that referenced this issue Sep 28, 2018
This is merging back Lionel Landwerlin aka @djdeath fork:
https://github.com/djdeath/pwm

Not yet tested, ARTIK710 has a pwm chip, not RPi.

Change-Id: I237a04669c23478a0a32a76623cec7cdd285bc94
Relate-to: EnotionZ#42
Signed-off-by: Philippe Coval <p.coval@samsung.com>
rzr added a commit to TizenTeam/GpiO that referenced this issue Sep 28, 2018
This is merging back Lionel Landwerlin aka @djdeath fork:
https://github.com/djdeath/pwm

Not yet tested, ARTIK710 has a pwm chip, not RPi.

Change-Id: I237a04669c23478a0a32a76623cec7cdd285bc94
Relate-to: EnotionZ#42
Signed-off-by: Philippe Coval <p.coval@samsung.com>
@EnotionZ
Copy link
Owner

@rzr Feel free to pull that in. Can you wait a day or two? I'm cleaning up the file right now to adhere to modern code style standards, just wanna avoid bumping into large conflicts.

@EnotionZ
Copy link
Owner

EnotionZ commented Oct 1, 2018

I think this issue is more-or-less resolved and we've created new PR/issues from this discussion. Closing issue.

@EnotionZ EnotionZ closed this as completed Oct 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants