adc: Add adc support based on sysfs #53
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Inpired by IoT.js API, tested on ARTIK710: ``` NODE_PATH=lib node example/adc-example.js 1745 ``` Change-Id: Ie9e006c667cbc39747c49251e41a7b25aa9d4607 Signed-off-by: Philippe Coval <p.coval@samsung.com>
rzr
force-pushed
the
sandbox/rzr/devel/adc/master
branch
from
903482c to
cdff624
Compare
|
Is this desired @EnotionZ or out of scope ? |
|
I think we should hold off merging this until we figure out a consistent way to define support for various boards as well as features outside of the standard read/write (such as adc, pwm, etc). When someone does a |
rzr
added a commit
to TizenTeam/webthing-node
that referenced
this pull request
Oct 1, 2018
To abstract different ADC or sysfs API, Note: later this class could land later in separate project (ie: gpio, iotjs-node? sysfs-node?) but since it's trivial let's share it here. Relate-to: EnotionZ/gpio#53 Change-Id: I923159901d3af3e1990ccf3e1510d561c2e0783b Signed-off-by: Philippe Coval <p.coval@samsung.com>
rzr
added a commit
to TizenTeam/webthing-node
that referenced
this pull request
Oct 1, 2018
To abstract different ADC or sysfs API, Note: later this class could land later in separate project (ie: gpio, iotjs-node? sysfs-node?) but since it's trivial let's share it here. Relate-to: EnotionZ/gpio#53 Change-Id: I923159901d3af3e1990ccf3e1510d561c2e0783b Signed-off-by: Philippe Coval <p.coval@samsung.com>
mrstegeman
pushed a commit
to WebThingsIO/webthing-node
that referenced
this pull request
Oct 1, 2018
* adc: Add Adc class To abstract different ADC or sysfs API, Note: later this class could land later in separate project (ie: gpio, iotjs-node? sysfs-node?) but since it's trivial let's share it here. Relate-to: EnotionZ/gpio#53 Change-Id: I923159901d3af3e1990ccf3e1510d561c2e0783b Signed-off-by: Philippe Coval <p.coval@samsung.com> * adc: Add AdcInProperty sensor class To support analog inputs Aligned to Gpio class Change-Id: Ic2b25cd172e9591fca4ce1e2920af92d2a218e0d Signed-off-by: Philippe Coval <p.coval@samsung.com> * artik: Support ADC properties Change-Id: I3e858f3a66e92546a3bba920a75d3fa299ae7c00 Signed-off-by: Philippe Coval <p.coval@samsung.com>
|
What do you think about preparing a new 'sysfs' module and try to keep 'gpio' one minimal ? |
|
is this project active? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inpired by IoT.js API
Change-Id: Ie9e006c667cbc39747c49251e41a7b25aa9d4607
Signed-off-by: Philippe Coval p.coval@samsung.com