Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BLOCKED] Bump react-scripts from 4.0.3 to 5.0.0 #696

Closed
wants to merge 1 commit into from
Closed

[BLOCKED] Bump react-scripts from 4.0.3 to 5.0.0 #696

wants to merge 1 commit into from

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Dec 14, 2021 •
edited
Loading

Bumps react-scripts from 4.0.3 to 5.0.0.

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code labels Dec 14, 2021
@mojotalantikite
Copy link
Contributor

@dependabot rebase

@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/react-scripts-5.0.0 branch 3 times, most recently from 5accfd5 to 3b2be82 Compare December 15, 2021 20:33
@haworku
Copy link
Contributor

haworku commented Dec 16, 2021

I wouldnt be surprised if this one fails. I will take this PR. I want to do reactscripts and react router upgrade together.

@haworku haworku self-assigned this Dec 16, 2021
@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/react-scripts-5.0.0 branch 5 times, most recently from 8fa7693 to 841c8ee Compare January 4, 2022 17:47
@haworku
Copy link
Contributor

haworku commented Jan 5, 2022 •
edited
Loading

Blocked - Not able to upgrade right now - cannot load absolute scss paths without error.

SassError: Can't find stylesheet to import.
@import 'uswds/src/stylesheets/theme/_uswds-theme-general.scss';      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

This is occuring for for every single vendor stylesheet (all of uswds).

Commented on this issue facebook/create-react-app#7023 but this could also be an issue with uswds

@haworku haworku changed the title Bump react-scripts from 4.0.3 to 5.0.0 [BLOCKED] Bump react-scripts from 4.0.3 to 5.0.0 Jan 5, 2022
@haworku haworku marked this pull request as draft January 5, 2022 16:50
@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/react-scripts-5.0.0 branch from 841c8ee to 887e26a Compare January 7, 2022 16:38
@haworku
Copy link
Contributor

haworku commented Jan 18, 2022

Another Truss project identified that the issue may be USWDS library needs to be updated to not use the newer Webpack 5 syntax for exports. PR to uswds may be forthcoming

@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/react-scripts-5.0.0 branch 2 times, most recently from 098e259 to c3f503d Compare January 18, 2022 18:44
@haworku
Copy link
Contributor

haworku commented Jan 19, 2022

uswds/uswds#4468

@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/react-scripts-5.0.0 branch 2 times, most recently from 79657b6 to 1a28c5b Compare January 29, 2022 00:18
@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/react-scripts-5.0.0 branch from 1a28c5b to d4dd4a0 Compare February 1, 2022 23:21
@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/react-scripts-5.0.0 branch from d4dd4a0 to 974f88d Compare February 14, 2022 15:45
@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/react-scripts-5.0.0 branch from 974f88d to 24ac877 Compare February 28, 2022 18:53
@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/react-scripts-5.0.0 branch 2 times, most recently from 5cbab82 to 6e67fd5 Compare March 15, 2022 18:58
@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/react-scripts-5.0.0 branch 2 times, most recently from 9423cff to 2fe9b73 Compare March 25, 2022 17:03
@dependabot @haworku
Bump react-scripts from 4.0.3 to 5.0.0
87509d3 
Bumps [react-scripts](https://github.com/facebook/create-react-app/tree/HEAD/packages/react-scripts) from 4.0.3 to 5.0.0.
- [Release notes](https://github.com/facebook/create-react-app/releases)
- [Changelog](https://github.com/facebook/create-react-app/blob/main/CHANGELOG.md)
- [Commits](https://github.com/facebook/create-react-app/commits/react-scripts@5.0.0/packages/react-scripts)

---
updated-dependencies:
- dependency-name: react-scripts
  dependency-type: direct:development
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
@haworku haworku force-pushed the dependabot/npm_and_yarn/react-scripts-5.0.0 branch from 1853ab3 to 87509d3 Compare April 1, 2022 15:21
@haworku
Copy link
Contributor

haworku commented Apr 4, 2022

Have a fresh branch going hw-upgrade-react-scripts

@haworku haworku closed this Apr 4, 2022
@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Apr 4, 2022

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version. You can also ignore all major, minor, or patch releases for a dependency by adding an ignore condition with the desired update_types to your config file.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

@dependabot dependabot bot deleted the dependabot/npm_and_yarn/react-scripts-5.0.0 branch April 4, 2022 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@haworku haworku

Labels
dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mojotalantikite @haworku