Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Issue 63] Increase the size of the receive buffer from 64 to 81 whic… #64

Merged
merged 1 commit into from
May 9, 2020
Merged

[Issue 63] Increase the size of the receive buffer from 64 to 81 whic… #64

merged 1 commit into from
May 9, 2020

Conversation

peterj43
Copy link
Contributor

@peterj43 peterj43 commented May 7, 2020

…h will allow a complete response to be received

@peterj43
[Issue 63] Increase the size of the receive buffer from 64 to 81 whic…
8543d95 
…h will allow a complete response to be received
@aufdenkampe
Copy link
Member

aufdenkampe commented May 7, 2020 •
edited
Loading

@peterj43, thanks for raising this issue in #63!

@Kevin-M-Smith, thanks for your responsiveness. Are you able to do the review before we merge?

Looping in @SRGDamia1

@aufdenkampe aufdenkampe requested a review from SRGDamia1 May 7, 2020 18:42
@SRGDamia1
Copy link
Contributor

May want to add an #ifndef bracketing the definition so that someone can change the buffer size at will

@SRGDamia1 SRGDamia1 merged commit 85fe96f into EnviroDIY:master May 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SRGDamia1 SRGDamia1 Awaiting requested review from SRGDamia1

Assignees

@Kevin-M-Smith Kevin-M-Smith

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@peterj43 @aufdenkampe @SRGDamia1 @Kevin-M-Smith