Add Alphasense CO2 Sensors; Redirect ADS1X15 dependency to Adafruit #457
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Addresses #456, including changing all uses of ADS1X15 to be compatible with breaking changes introduced with Adafruit's v2.x releases. Everything compiles!
Haven't yet tried to compile!
Will commit example to https://github.com/bellahenkel/Soil-Sensing-Device
because Adafruit's v2 library does it in two steps, with `ads.readADC_SingleEnded()` returning a raw ADC count integer, which then needs to be comverted into an ADC voltage float.
|
@bellahenkel, can you confirm that the Alphasense CO2 sensor is working using this sketch: |
|
@aufdenkampe Everything appears to be working on my end! |
|
@SRGDamia1, is this something you might be able to review and merge sooner than later? I think this feature branch adds important new capabilities and ease-of-use benefits (i.e. all recent tutorials use Adafruit's v2 for ADS1X15) that are outlined in: |
aufdenkampe
added this to the v0.36: Batch transmission; Adafruit_ADS1X15 v2; Alphasense CO2 sensor milestone
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is primarily to add the Alphasense IRC-A1 Nondispersive Infrared (NDIR) Carbon Dioxide (CO2) sensor to the list of supported sensors.
It also paves the way for other Alphasense gas sensors to be implemented.
Last, bundled into this PR is a code fix to support the following change in the dependency for the Mayfly's Analog-to-Digital Converter (ADC):
There are many compelling reasons to switch this core dependency, as described in the issue.
This PR is not yet 100% ready, as some testing is first required to confirm that everything is working on sensors that use the ADS1X15. I also need to complete documentation for the Alphasense sensor, primarily via adding a block to the
menu-a-la-carte.inoexample.This PR begins such review.