Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

List breaking changes for v0.13? #1861

Closed
gdalle opened this issue Sep 19, 2024 · 9 comments
Closed

List breaking changes for v0.13? #1861

gdalle opened this issue Sep 19, 2024 · 9 comments

Comments

@gdalle
Copy link
Contributor

gdalle commented Sep 19, 2024

Hi, well done on the new release!
Would it be possible to list the major breaking changes somewhere?

@wsmoses
Copy link
Member

wsmoses commented Sep 19, 2024

Yup we will make an announcement once we’ve done the sweep to help various ecosystem deps.

@wsmoses wsmoses closed this as completed Sep 19, 2024
@gdalle
Copy link
Contributor Author

gdalle commented Sep 19, 2024

I don't know about the other deps but if you want DI to update I kinda need to know the breaking changes first ^^

@gdalle
Copy link
Contributor Author

gdalle commented Sep 19, 2024

Especially since most of the PRs have no description whatsoever

@ExpandingMan
Copy link
Contributor

Not sure if you were suggesting waiting for dependencies to update, but the dependencies themselves are of course the things that are most in need of a detailed list of breaking changes.

@wsmoses
Copy link
Member

wsmoses commented Sep 19, 2024

yeah but first I need to fix the fact that GPU tests rn result in a circular dependency between Enzyme <-> CUDA <-> KernelAbstractions, so neither can successfully run tests presently, so there might be some minor changes as these get mutually re-compatible again

=> I wouldn't consider this officially released [tho it is practically ATM for the sake of fixing related nonsense], until that's resolved

@gdalle
Copy link
Contributor Author

gdalle commented Sep 19, 2024

Okay, thanks for the clarification. May I suggest at least adding a big old warning to the release notes of v0.13? People who are not in the loop like we are may be very surprised if minor changes happen after a breaking release was theoretically stabilized. Something like

Warning

We are still ironing out the details of the breaking release v0.13. A list of changes will follow, but for now most people probably shouldn't update to the latest version.

@wsmoses
Copy link
Member

wsmoses commented Sep 19, 2024 via email

@wsmoses
Copy link
Member

wsmoses commented Sep 19, 2024

Especially since presently I expect no breaking changes, and the only changes that are happening in practice are minor implementation changes to the various extensions [CudaEnzyme, CudaKA, KAEnzyme, etc]. Of course if something doesn't work and needs a breaking change there to successfully run, so be it.

@gdalle
Copy link
Contributor Author

gdalle commented Sep 19, 2024

Fair enough. I'll try to update DI and see what breaks there too

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants