-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
List breaking changes for v0.13? #1861
Comments
Yup we will make an announcement once we’ve done the sweep to help various ecosystem deps. |
I don't know about the other deps but if you want DI to update I kinda need to know the breaking changes first ^^ |
Especially since most of the PRs have no description whatsoever |
Not sure if you were suggesting waiting for dependencies to update, but the dependencies themselves are of course the things that are most in need of a detailed list of breaking changes. |
yeah but first I need to fix the fact that GPU tests rn result in a circular dependency between Enzyme <-> CUDA <-> KernelAbstractions, so neither can successfully run tests presently, so there might be some minor changes as these get mutually re-compatible again => I wouldn't consider this officially released [tho it is practically ATM for the sake of fixing related nonsense], until that's resolved |
Okay, thanks for the clarification. May I suggest at least adding a big old warning to the release notes of v0.13? People who are not in the loop like we are may be very surprised if minor changes happen after a breaking release was theoretically stabilized. Something like Warning We are still ironing out the details of the breaking release v0.13. A list of changes will follow, but for now most people probably shouldn't update to the latest version. |
I mean if you want to, go for it, but the details should hopefully be
resolved in the next day or two so I personally wouldn’t bother
…On Thu, Sep 19, 2024 at 2:34 PM Guillaume Dalle ***@***.***> wrote:
Okay, thanks for the clarification. May I suggest at least adding a big
old warning to the release notes of v0.13? People who are not in the loop
like we are may be very surprised if minor changes happen after a breaking
release was theoretically stabilized. Something like
Warning
We are still ironing out the details of the breaking release v0.13. A list
of changes will follow, but for now most people probably shouldn't update
to the latest version.
—
Reply to this email directly, view it on GitHub
<#1861 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAJTUXGCIFKMD6OQG23H27TZXMRNBAVCNFSM6AAAAABOPHUHJSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGNRSGAZDOMZYGQ>
.
You are receiving this because you modified the open/close state.Message
ID: ***@***.***>
|
Especially since presently I expect no breaking changes, and the only changes that are happening in practice are minor implementation changes to the various extensions [CudaEnzyme, CudaKA, KAEnzyme, etc]. Of course if something doesn't work and needs a breaking change there to successfully run, so be it. |
Fair enough. I'll try to update DI and see what breaks there too |
Hi, well done on the new release!
Would it be possible to list the major breaking changes somewhere?
The text was updated successfully, but these errors were encountered: