Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make zero in place #1518

Merged
merged 3 commits into from
Jun 8, 2024
Merged

Make zero in place #1518

merged 3 commits into from
Jun 8, 2024

Conversation

wsmoses
Copy link
Member

@wsmoses wsmoses commented Jun 6, 2024

It's 2 am so I'lls tart this later, but something like this.

cc @ChrisRackauckas

Copy link
Contributor

github-actions bot commented Jun 6, 2024

Benchmark Results

main ee3bffb... main/ee3bffb20dd94a...
basics/overhead 4.95 ± 0.01 ns 4.34 ± 0.001 ns 1.14
time_to_load 0.353 ± 0.0034 s 0.353 ± 0.0026 s 0.999

Benchmark Plots

A plot of the benchmark results have been uploaded as an artifact to the workflow run for this PR.
Go to "Actions"->"Benchmark a pull request"->[the most recent run]->"Artifacts" (at the bottom).

Project.toml Outdated Show resolved Hide resolved
@wsmoses wsmoses force-pushed the mzip branch 5 times, most recently from dcac7b6 to f60ee3c Compare June 7, 2024 23:08
@wsmoses wsmoses marked this pull request as ready for review June 7, 2024 23:11
@ChrisRackauckas
Copy link
Contributor

I feel like make_zero and make_zero! should be moved out of Enzyme as a general Julia tool, even to Base as the standard zero function extension. I kind of just use it everywhere...

@wsmoses
Copy link
Member Author

wsmoses commented Jun 8, 2024

Not opposed, but have to start somewhere.

@wsmoses wsmoses merged commit df9bff9 into main Jun 8, 2024
38 of 49 checks passed
@wsmoses wsmoses deleted the mzip branch June 8, 2024 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants