Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fastgen2 #532

Closed
wants to merge 28 commits into from
Closed

Fastgen2 #532

wants to merge 28 commits into from

Conversation

wsmoses
Copy link
Member

@wsmoses wsmoses commented Oct 24, 2022

Reduces from 4ms down to 650us. Still far from the 5.5us possible.

Currently only working forward diff, can also get augmented fwd. Reverse requires some thought.

@wsmoses wsmoses requested a review from vchuravy October 24, 2022 08:15
@wsmoses wsmoses marked this pull request as ready for review October 25, 2022 03:52
@codecov-commenter
Copy link

codecov-commenter commented Oct 25, 2022

Codecov Report

Base: 76.09% // Head: 75.77% // Decreases project coverage by -0.31% ⚠️

Coverage data is based on head (1ee2c6c) compared to base (e8893b7).
Patch coverage: 81.31% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #532      +/-   ##
==========================================
- Coverage   76.09%   75.77%   -0.32%     
==========================================
  Files          17       17              
  Lines        5690     5966     +276     
==========================================
+ Hits         4330     4521     +191     
- Misses       1360     1445      +85     
Impacted Files Coverage Δ
src/Enzyme.jl 86.04% <ø> (ø)
src/compiler.jl 77.27% <81.31%> (+1.17%) ⬆️
src/compiler/orcv1.jl 0.00% <0.00%> (-76.93%) ⬇️
src/compiler/utils.jl 57.53% <0.00%> (-38.36%) ⬇️
src/compiler/validation.jl 57.68% <0.00%> (-4.39%) ⬇️
src/typetree.jl 88.09% <0.00%> (-0.80%) ⬇️
src/compiler/orcv2.jl 66.32% <0.00%> (+4.42%) ⬆️
src/compiler/pmap.jl 82.85% <0.00%> (+5.31%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@vchuravy
Copy link
Member

Is this still needed with fastgen3?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants