Add NoFree cmd line fallback

EnzymeAD · Dec 17, 2023 · 5b15cf1 · 5b15cf1
1 parent fb6a1c6
commit 5b15cf1
Show file tree

Hide file tree

Showing 4 changed files with 15 additions and 0 deletions.
diff --git a/enzyme/CMakeLists.txt b/enzyme/CMakeLists.txt
@@ -310,6 +310,8 @@ export(TARGETS LLDEnzyme-${LLVM_VERSION_MAJOR}
 
 export(TARGETS LLDEnzymeFlags
     APPEND FILE "${PROJECT_BINARY_DIR}/EnzymeTargets.cmake")
+export(TARGETS LLDEnzymeAssumeUnknownNoFree
+    APPEND FILE "${PROJECT_BINARY_DIR}/EnzymeTargets.cmake")
 export(TARGETS LLDEnzymeLooseTypeFlags
     APPEND FILE "${PROJECT_BINARY_DIR}/EnzymeTargets.cmake")
 export(TARGETS LLDEnzymePrintTypeFlags

diff --git a/enzyme/Enzyme/CMakeLists.txt b/enzyme/Enzyme/CMakeLists.txt
@@ -170,6 +170,9 @@ if (${LLVM_VERSION_MAJOR} GREATER 14)
     target_link_options(LLDEnzymeFlags INTERFACE "SHELL: -Wl,--load-pass-plugin=$<TARGET_FILE:LLDEnzyme-${LLVM_VERSION_MAJOR}>")
 endif()
 
+add_library(LLDEnzymeAssumeUnknownNoFree INTERFACE)
+target_link_options(LLDEnzymeAssumeUnknownNoFree INTERFACE "SHELL: -Wl,-mllvm -Wl,-enzyme-assume-unknown-nofree=1")
+
 add_library(LLDEnzymeLooseTypeFlags INTERFACE)
 target_link_options(LLDEnzymeLooseTypeFlags INTERFACE "SHELL: -Wl,-mllvm -Wl,-enzyme-loose-types=1")
 

diff --git a/enzyme/Enzyme/EnzymeLogic.cpp b/enzyme/Enzyme/EnzymeLogic.cpp
@@ -103,6 +103,10 @@ cl::opt<bool> EnzymeJuliaAddrLoad(
     "enzyme-julia-addr-load", cl::init(false), cl::Hidden,
     cl::desc("Mark all loads resulting in an addr(13)* to be legal to redo"));
 
+cl::opt<bool> EnzymeAssumeUnknownNoFree(
+    "enzyme-assume-unknown-nofree", cl::init(false), cl::Hidden,
+    cl::desc("Assume unknown instructions are nofree as needed"));
+
 LLVMValueRef (*EnzymeFixupReturn)(LLVMBuilderRef, LLVMValueRef) = nullptr;
 }
 
@@ -5220,6 +5224,10 @@ llvm::Value *EnzymeLogic::CreateNoFree(RequestContext context,
     return todiff;
   }
 
+  if (EnzymeAssumeUnknownNoFree) {
+    return todiff;
+  }
+
   if (context.req) {
     EmitFailure("IllegalNoFree", context.req->getDebugLoc(), context.req,
                 "Cannot create nofree of instruction-created value: ", *todiff);

diff --git a/enzyme/cmake/EnzymeConfig.cmake.in b/enzyme/cmake/EnzymeConfig.cmake.in
@@ -12,6 +12,7 @@ set(Enzyme_TABLEGEN_EXE "@Enzyme_CONFIG_TABLEGEN_EXE@")
 
 # Our library dependencies (contains definitions for IMPORTED targets)
 if(NOT TARGET ClangEnzymeFlags AND NOT TARGET LLDEnzymeFlags 
+    AND NOT TARGET LLDEnzymeAssumeUnknownNoFree
     AND NOT TARGET LLDEnzymeLooseTypeFlags
     AND NOT TARGET LLDEnzymePrintTypeFlags
     AND NOT TARGET LLDEnzymePrintFlags
@@ -20,6 +21,7 @@ if(NOT TARGET ClangEnzymeFlags AND NOT TARGET LLDEnzymeFlags
     include("${Enzyme_CMAKE_DIR}/EnzymeTargets.cmake")
     # These are IMPORTED targets created by EnzymeTargets.cmake
     set(Enzyme_LIBRARIES ClangEnzymeFlags LLDEnzymeFlags
+        LLDEnzymeAssumeUnknownNoFree
         LLDEnzymeLooseTypeFlags
         LLDEnzymePrintTypeFlags
         LLDEnzymePrintFlags