Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: define getindexing into sub reshaped array #556

Merged
merged 2 commits into from
Jan 17, 2025
Merged

fix: define getindexing into sub reshaped array #556

merged 2 commits into from
Jan 17, 2025

Conversation

avik-pal
Copy link
Collaborator

fixes #555

wsmoses
wsmoses approved these changes Jan 17, 2025
View reviewed changes
Copy link
Member

@wsmoses wsmoses left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm but can you add that test?

@avik-pal avik-pal merged commit 6310f83 into main Jan 17, 2025
30 of 39 checks passed
@avik-pal avik-pal deleted the ap/patch_subarray branch January 17, 2025 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wsmoses wsmoses wsmoses approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Subarray indexing error
2 participants
@avik-pal @wsmoses