Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Profiler annotations & tutorial #582

Merged
merged 7 commits into from
Jan 20, 2025
Merged

Profiler annotations & tutorial #582

merged 7 commits into from
Jan 20, 2025

Conversation

Pangoraw
Copy link
Collaborator

Closes #581.

mofeing
mofeing reviewed Jan 20, 2025
View reviewed changes
docs/src/tutorials/images/perfetto.png
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are these screenshots by us or are they taken from somewhere?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

by us, those are from the example

wsmoses
wsmoses approved these changes Jan 20, 2025
View reviewed changes
Copy link
Member

@wsmoses wsmoses left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic! Maybe also add a line about the allocator stats in the tutorial too?

@wsmoses wsmoses merged commit 2be46df into EnzymeAD:main Jan 20, 2025
32 of 38 checks passed
@Pangoraw Pangoraw deleted the profiler-annotations branch January 20, 2025 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mofeing mofeing mofeing left review comments

@wsmoses wsmoses wsmoses approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Profiling Tutorial
3 participants
@Pangoraw @wsmoses @mofeing