-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
wip, adding rust #3
Conversation
For the Rust side we have changes to rustc itself, so there is no way to just link Enzyme in. Also, could you make me a contributor please, so I can create PRs against this repo directly and see what CI says? |
I'd like to get this going and would be able to host the builder for new rust-enzyme images. Are there docs somewhere for what is needed, or someone who can advise assuming I can build a Rust toolchain in whatever environment you like? |
For deployment somebody just needs to run update.sh on the enzyme-ce machine (just ping me). Also feel free to reach out if I can help in any way. |
If possible, I'd like to reduce the frequency of the rust rebuilds to nightly (rather than the Enzyme rebuild which does much more frequently), to ensure latency of EnzymeCore updates is reasonable. |
I don't think it can be reasonably built from scratch on a 4c gh runner, so I think for now it's better if Jed hosts it completely and we just download artifacts here. I feel like once Enzyme can be build against the pre-build LLVM from Rust's official download-CI it would make sense to move it over. Also, Enzyme is just a .so here, so I assume it should later be possible to silently delete it and replace it by a newer LLVMEnzyme.so, without rebuilding Rust (assuming no breaking Enzym change). |
Is there anything preventing that right now? Enzyme works on llvm main |
Yes, it's the discussion we had here: Nvm,we had it in an Enzyme weekly meeting. |
I think you forgot to add a link since I don't see anything after the colon. In any case, if you're referring to the MSVC issue, that only makes it difficulty to build with MSVC in windows. Since the this is built with clang/gcc (and on Linux), it should be fine. |
created Rust issue (though it could live in Enzyme core too) |
Given that there is no progress on building Enzyme on Rust's LLVM, lets keep the Rust version fixed. |
@ZuseZ4 Just download it inside https://github.com/EnzymeAD/enzyme-explorer/blob/main/builder/install-compilers.sh. The binary should run on ubuntu 22.
|
@jedbrown Shall we give this another try, now that we have a working Rust CI? I assume it should be possible to just pull in the latest artifact from /rust? |
Thanks. It's probably possible to tar up the whole build directory, but I wanted to get |
@ZuseZ4 you could add the rustc tar as a binary artefact to a release. |
closed-ish by 6f73fd0 |
hm something is still awry:
|
Yep, but we're aware of it and looking into fixes. |
No description provided.