Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Locales are not properly importable in Typescript #2719

Closed
3 tasks done
Thodor12 opened this issue Nov 10, 2022 · 1 comment
Closed
3 tasks done

Locales are not properly importable in Typescript #2719

Thodor12 opened this issue Nov 10, 2022 · 1 comment

Comments

@Thodor12
Copy link

Prerequisites

Describe the issue

According to the documentation for Typescript you simply have to import the locale files directly, but Typescript is throwing errors about missing declaration files, whilst this does not immediately inhibit runtime functionality, it should also not throw errors and just provide the typings correctly.

StackBlitz fork

https://stackblitz.com/edit/v6-typescript-d6rf8f?file=index.ts

What operating system(s) are you seeing the problem on?

Windows

What browser(s) are you seeing the problem on?

Chrome

What version of are you using? You can find this information from the sample StackBlitz.

6.2.7

What your browser's locale? You can find this information from the sample StackBlitz.

nl-NL

@Thodor12 Thodor12 added the State: Triage Tickets that need to be triaged. label Nov 10, 2022
@Eonasdan Eonasdan added Type: Bug v6 Area: TypeScript Priority: Low and removed State: Triage Tickets that need to be triaged. labels Dec 5, 2022
@Eonasdan Eonasdan moved this to 🆕 New in Tempus Dominus Dec 5, 2022
@Eonasdan Eonasdan moved this from 🆕 New to 🔖 Ready in Tempus Dominus Dec 5, 2022
@Eonasdan Eonasdan moved this from 🔖 Ready to 🏗 In progress in Tempus Dominus Dec 12, 2022
Eonasdan added a commit that referenced this issue Dec 12, 2022
@Eonasdan
Copy link
Owner

Hi. I think I fixed this in the attached branch. I created a SB for this but I think the cache is behind (at least for me) https://stackblitz.com/edit/typescript-y2nxnt?file=index.ts. If you can test it from the branch, great. If not, I'll probably just merge the changes in and verify after a version bump.

@Eonasdan Eonasdan moved this from 🏗 In progress to 👀 In review in Tempus Dominus Dec 13, 2022
Eonasdan added a commit that referenced this issue Dec 14, 2022
* playing with jsdom

* seems to work

* working on tests

* fixes #2719.

* rollback

* add locales/plugin source and types to npm

* put version back

* update cdn references
@Eonasdan Eonasdan moved this from 👀 In review to ✅ Done in Tempus Dominus Dec 14, 2022
@Eonasdan Eonasdan moved this from ✅ Done to 🚀 Released in Tempus Dominus Dec 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

When branches are created from issues, their pull requests are automatically linked.

2 participants