Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Infinite loop, browser freeze #2788

Closed
3 tasks done
ivanhennig opened this issue Apr 4, 2023 · 1 comment
Closed
3 tasks done

Infinite loop, browser freeze #2788

ivanhennig opened this issue Apr 4, 2023 · 1 comment
Labels
Area: TypeScript Priority: High State: Pending Release This issue has been resolved in the dev branch and is waiting on a new release Type: Bug

Comments

@ivanhennig
Copy link

ivanhennig commented Apr 4, 2023

Prerequisites

Describe the issue

I've create an instance using the following options:

  {
    localization: {
      locale: 'default',
      selectTime: 'Mudar para hora',
      selectDate: 'Mudar para data',
      format: 'L LT',
      dateFormats: {
        LTS: 'HH:mm:ss',
        LT: 'HH:mm',
        L: 'dd/MM/yyyy',
        LL: 'd [de] MMMM [de] yyyy',
        LLL: 'd [de] MMMM [de] yyyy H:mm',
        LLLL: 'dddd, d [de] MMMM [de] yyyy H:mm',
      },
    },
    display: {
      icons: {
        time: 'bi bi-clock',
        date: 'bi bi-calendar3',
        up: 'bi bi-chevron-compact-up',
        down: 'bi bi-chevron-compact-down',
        previous: 'bi bi-chevron-compact-left',
        next: 'bi bi-chevron-compact-right',
        today: 'bi bi-calendar2-check',
        clear: 'bi bi-trash3',
        close: 'bi bi-x-lg',
      },
      components: {
        calendar: true,
        date: true,
        month: true,
        year: true,
        decades: true,
        clock: true,
        hours: true,
        minutes: true,
        seconds: false,
      },
      buttons: {
        clear: true,
        close: true,
      },
    },
    dateRange: true,
    useCurrent: 'day',
    stepping: 10,
  }

Please note the dateRange in options. Things runs fine clicking in the start and the end date of a range, however if the user clicks twice on the same date the browser just hang

StackBlitz fork

https://stackblitz.com/edit/tempus-dominus-v6-simple-setup-xbdyek?file=index.js

What operating system(s) are you seeing the problem on?

Windows

What browser(s) are you seeing the problem on?

Chrome

What version of are you using? You can find this information from the sample StackBlitz.

6.4.4

What your browser's locale? You can find this information from the sample StackBlitz.

pt-BR

@ivanhennig ivanhennig added State: Triage Tickets that need to be triaged. Type: Bug labels Apr 4, 2023
@github-project-automation github-project-automation bot moved this to 🆕 New in Tempus Dominus Apr 4, 2023
@Eonasdan Eonasdan added Area: TypeScript Priority: High and removed State: Triage Tickets that need to be triaged. labels Apr 9, 2023
iTzVirtual00 added a commit to iTzVirtual00/tempus-dominus that referenced this issue Apr 9, 2023
Break if current range-start is clicked to prevent infinite loop.
iTzVirtual00 added a commit to iTzVirtual00/tempus-dominus that referenced this issue Apr 9, 2023
Break if current range-start is clicked to prevent infinite loop
Eonasdan pushed a commit that referenced this issue Apr 10, 2023
Break if current range-start is clicked to prevent infinite loop
@Eonasdan Eonasdan moved this from 🆕 New to 👀 In review in Tempus Dominus Apr 10, 2023
@Eonasdan Eonasdan moved this from 👀 In review to ✅ Done in Tempus Dominus Apr 10, 2023
@Eonasdan Eonasdan added the State: Pending Release This issue has been resolved in the dev branch and is waiting on a new release label Apr 10, 2023
Eonasdan pushed a commit that referenced this issue Apr 22, 2023
Break if current range-start is clicked to prevent infinite loop
@Eonasdan
Copy link
Owner

Hello 6.7.7 is published with this fix. Thanks again

@Eonasdan Eonasdan moved this from ✅ Done to 🚀 Released in Tempus Dominus Apr 22, 2023
Eonasdan added a commit that referenced this issue May 22, 2023
* Fix #2788 (#2790)

Break if current range-start is clicked to prevent infinite loop

* adding placement option (#2789)

* fixes #2785 (#2797)

* fixes #2785
fixes #2783
fixes #2768
improves docs flow

* fixed plugin/locale missing type defs

* 2791 more tests (#2800)

* validation tests
* update datetime tests
* "dates" tests
* actions tests

* fixing infinity loop bug in date range (#2798)

* Improvements (#2801)

* fixes #2795
* fixes #2784
* fixes #2687
* fixes #2786
* resolves #2764
* fix repl cdn links
* fix date range bug

* version 6.7.7

* version 6.7.7

---------

Co-authored-by: iTzVirtual_ <58611844+iTzVirtual00@users.noreply.github.com>
Co-authored-by: Killian Hale <hale.killian@gmail.com>
Co-authored-by: GitHub User <abdelrahman_nasr99@hotmail.com>
Eonasdan added a commit that referenced this issue Jul 3, 2023
* Fix #2788 (#2790)

Break if current range-start is clicked to prevent infinite loop

* adding placement option (#2789)

* fixes #2785 (#2797)

* fixes #2785
fixes #2783
fixes #2768
improves docs flow

* fixed plugin/locale missing type defs

* 2791 more tests (#2800)

* validation tests
* update datetime tests
* "dates" tests
* actions tests

* fixing infinity loop bug in date range (#2798)

* Improvements (#2801)

* fixes #2795
* fixes #2784
* fixes #2687
* fixes #2786
* resolves #2764
* fix repl cdn links
* fix date range bug

* version 6.7.7

* version 6.7.7

---------

Co-authored-by: iTzVirtual_ <58611844+iTzVirtual00@users.noreply.github.com>
Co-authored-by: Killian Hale <hale.killian@gmail.com>
Co-authored-by: GitHub User <abdelrahman_nasr99@hotmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: TypeScript Priority: High State: Pending Release This issue has been resolved in the dev branch and is waiting on a new release Type: Bug
Projects
Archived in project
Development

No branches or pull requests

2 participants