#221 [QuickCreation] add: add const + check statut #256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evarisk-francois
requested review from
evarisk-micka
and removed request for
nicolas-eoxia
nicolas-eoxia
requested changes
Jul 3, 2024
| @@ -81,7 +81,7 @@ | |||
| $project->opp_amount = price2num(GETPOST('opp_amount', 'int')); | |||
| $project->date_c = dol_now(); | |||
| $project->date_start = dol_now(); | |||
| $project->statut = 1; | |||
| $project->statut = getDolGlobalInt('EASYCRM_PWA_CLOSE_PROJECT_WHEN_OPPORTUNITY_ZERO') > 0 ? 2 : 1; | |||
There was a problem hiding this comment.
Il faut éviter d'écrire les valeurs en dur lorsqu'il s'agit de constante
Regarder les constantes de projet pour faire le fix
Il manque un check sur opp_percent
core/modules/modEasyCRM.class.php
Outdated
| @@ -218,6 +218,9 @@ public function __construct($db) | |||
| $i++ => ['EASYCRM_EVENT_DESCRIPTION_VISIBLE', 'integer', 1, '', 0, 'current'], | |||
| $i++ => ['EASYCRM_EVENT_CATEGORIES_VISIBLE', 'integer', 1, '', 0, 'current'], | |||
|
|
|||
| // CONST PWA | |||
| $i++ => ['EASYCRM_PWA_CLOSE_PROJECT_WHEN_OPPORTUNITY_ZERO', 'integer', 1, '', 0, 'current'], | |||
There was a problem hiding this comment.
Ici il faut pas set la conf a 1 c'est un comportement spécifique que l'utilisateur peut configurer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.