Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #113 - Add A* to rush Dungeon #116

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

akwawa
Copy link
Contributor

@akwawa akwawa commented May 27, 2022

We don't take chests or fight for nothing.
The general gain is better on the hardest dungeons (more time to kill enemies needed than dungeons where the player can OS all enemies).

I use the A* from here: http://github.com/bgrins/javascript-astar
And minified it.

We don't take chests or fight for nothing.
The general gain is better on the hardest dungeons (more time to kill enemies needed than first dungeon where the player can OS all enemies)
@akwawa
Copy link
Contributor Author

akwawa commented May 27, 2022

Please, test it before merging.
I had done a lot of "write/undo" before the script was 100% functional.

@EugeneFabre
Copy link

This needs to be implemented better since I don't know how exactly to do it well but you don't even need pathfinding with:

    if (!DungeonRunner.fightingBoss()) {
  DungeonRunner.fightingBoss(true);
  DungeonBattle.generateNewBoss();
    }

@akwawa
Copy link
Contributor Author

akwawa commented May 28, 2022

Hello @EugeneFabre,

I don't want to implement your code.
your code is an extract of this :

    public static startBossFight() {
        if (DungeonRunner.map.currentTile().type() !== GameConstants.DungeonTile.boss || DungeonRunner.fightingBoss()) {
            return;
        }

        DungeonRunner.fightingBoss(true);
        DungeonBattle.generateNewBoss();
    }

This code verifies that you are in the correct tile before launching the fight.
If you remove this and just do the fight, it looks like a "hack".
I'm not a fan to do this.
I prefer to keep the global situation than just hack the game.

When your use your code, the first line said your find the Boss and the 2nd line start the fight.
You can use it while standing in the entrance tile.

As said before, I don't want/like to use this method and I will not implement them.

@Ephenia Ephenia added the Merge Conflicting This means that this PR has a merge conflict and it will need to be revised label Apr 19, 2023
@Ephenia Ephenia added the Insufficient votes This means the PR lacks votes and requires more attention for a decision to be made label Apr 29, 2023
@elrandira
Copy link

I think this PR can be closed as #352 covered this

@umbralOptimatum
Copy link
Contributor

That PR uses a different method, but I do feel this should be closed as the algorithm relies on information the player doesn't have.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Insufficient votes This means the PR lacks votes and requires more attention for a decision to be made Merge Conflicting This means that this PR has a merge conflict and it will need to be revised
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants