This repository has been archived by the owner on Mar 1, 2024. It is now read-only.
Fixing matchmaker directing users to http when the signalling server is using https #245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant components:
Problem statement:
When the signalling server is configured to use HTTPS the matchmaker would still direct the users to the HTTP port. See #207
Solution
When the signalling server starts and communicates with the matchmaker it now supplies the correct HTTP or HTTPS port based on config.UseHTTPS allowing the matchmaker to redirect users to the correct port.
Test Plan and Compatibility
Run the matchmaker with or without HTTPS and attempt running the signalling server with and without UseHTTPS configurations. Make sure that the matchmaker directs the user to the correct port and the streaming application runs as expected.