Bug fix to retrieve the correct selected ice candidate pair #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
david-macpherson
changed the title
david-macpherson
changed the title
lukehb
requested changes
Mar 12, 2024
Frontend/library/src/PeerConnectionController/AggregatedStats.ts
Outdated
Show resolved
Hide resolved
Frontend/library/src/PeerConnectionController/AggregatedStats.ts
Outdated
Show resolved
Hide resolved
lukehb
added
auto-backport
github-actions bot
pushed a commit
that referenced
this pull request
Mar 12, 2024
(cherry picked from commit fd24a45)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
lukehb
pushed a commit
that referenced
this pull request
Mar 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant components:
Problem statement:
The active candidate pair returned from the
AggregatedStats.getActiveCandidatePairfunction is returning the 1st candidate pair element which has received any bytes, some browsers will receive data on multiple candidate pairs which is not the selected candidate pairSolution
Implement the handling of the
RTCTransportStatsfrom theRTCStatsReportRetrieve the selected candidate pair from the list of candidate pairs using the
selectedcandidatepairidfrom theRTCTransportStatsDue to
browser_compatibilityfire fox doesn't supportRTCTransportStatsIn the case of the
RTCTransportStatsbeing undefined fall back to use theselectedproperty of theRTCIceCandidatePairStats