Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update docker scripts to not clone from github or use static copies of the source #35

Closed
4 tasks done
hjwilli opened this issue May 31, 2018 · 4 comments
Closed
4 tasks done
Assignees

Comments

@hjwilli
Copy link
Collaborator

hjwilli commented May 31, 2018

Part of the docker setup process for all three containers clones pennai:master into /opt/. The docker build process seems to rely on /opt/ (for example the lab Dockerfile runs 'RUN npm install...' from /opt/). The running containers seem to optionally rely on the contents of /opt/ or the local version of pennai as exposed via a docker shared drive.

This seems confusing and error prone, especially if there is a mismatch between local files and github master. Determine if there was a reason for cloning the project (perhaps as part of AWS deployment?). If it makes sense, update the deployment scripts to copy from the local to /opt/ instead of cloning from github. Attempt to copy only what is necessary for the given container (see #34)

  • Move git clone from the base docker image to lab, machine, dbmongo
  • Remove git clone from lab
  • Remove git clone from machine
  • Remove git clone from dbmongo
@weixuanfu
Copy link
Contributor

weixuanfu commented Jun 1, 2018

OK, I will work on this line

@hjwilli hjwilli self-assigned this Jun 1, 2018
@hjwilli hjwilli changed the title update docker scripts to not clone from github? update docker scripts to not clone from github Jun 1, 2018
@hjwilli
Copy link
Collaborator Author

hjwilli commented Jun 1, 2018

After discussion with @weixuanfu, there doesn't seem to be a good reason to clone from github, this will be removed.

hjwilli added a commit that referenced this issue Jun 1, 2018
Small dockerfile cleanup
Move git clone from base container to the subcontainers
References #35 #33
@weixuanfu weixuanfu self-assigned this Jun 4, 2018
@weixuanfu
Copy link
Contributor

I just pushed some commits to pennai_lite branch to remove git clone in those containers.

hjwilli added a commit that referenced this issue Jun 4, 2018
Remove git clone from dbmongo
References #35
@hjwilli
Copy link
Collaborator Author

hjwilli commented Jun 8, 2018

Clone has been removed, a static compressed file of a portion of the codebase is now being used to populate /opt. It seems like this is being used to configure how anaconda is set up, may also be used for data initialization for machine, lab and dbmongo.

Will try to factor out the need to copy some of the source tree into /opt.

@hjwilli hjwilli changed the title update docker scripts to not clone from github update docker scripts to not clone from github or use static copies of the source Jun 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants