Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests for speechbrain tutorial #1007

Open
wants to merge 31 commits into
base: develop
Choose a base branch
from

Conversation

Simnol22
Copy link
Contributor

Description

Basic tests for the SpeechBrain model example we are adding to the doc,.

Changes

Adding of some tests, as well as a download_data.py script.

Tests

  • I added corresponding tests for bug fixes and new features. If possible, the tests fail without the changes
  • [x ] All new and existing tests are passing ($ tox -e py38; replace 38 by your Python version if necessary)

Documentation

  • [ x] I have updated the relevant documentation related to my changes

Quality

  • [ x] I have read the CONTRIBUTING doc
  • [ x] My commits messages follow this format
  • [ x] My code follows the style guidelines ($ tox -e lint)

output = data / "results"

"""Calling the script, for downloading the data"""
script = os.path.abspath("examples/speechbrain_tutorial/download_data.py")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would be more robust if it would start from this modules directory and get the relative path. Otherwise this test only works if we executed it from repo's root.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure I understand what do you mean here. Were you thinking something like str(os.path.dirname(os.path.abspath(__file__))) + "/../../speechbrain_tutorial/main.py" ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Exact!

@bouthilx
Copy link
Member

The pre-trained model is too large for github-actions' runner. We would need to have a local hosted runner for this. We'll take a look at this and then revisit this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants