Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User panel takes too long to load #982

Closed
ccuser44 opened this issue Jan 21, 2023 · 4 comments · Fixed by #1407
Closed

User panel takes too long to load #982

ccuser44 opened this issue Jan 21, 2023 · 4 comments · Fixed by #1407
Labels
🐛 bug Bugs or broken features ✨ enhancement Enhancing or improving existing functionality 📝 minor Very small, narrow or generally unimportant issues/enhancements 📱 UI Frontend Adonis user interfaces

Comments

@ccuser44
Copy link
Contributor

ccuser44 commented Jan 21, 2023

  • To see the bug click the Adonis help button to load the user panel. It doesn't load instrantly
  • The expected behavior is that user panel would load instantly
  • The actual results are that the menu takes 0.5-3 seconds to load on a normal game. If there is lag it might take forever
  • The impacts of this bug are that it's annoying to wait for the menu to load. If the server is laggy or you have a low internet or otherwise there is network lag it might take minutes to load.

The bug is caused by these lines of codes in UserPanel.lua

local playerData = Remote.Get("PlayerData")
local chatMod = Remote.Get("Setting",{"Prefix","SpecialPrefix","BatchKey","AnyPrefix","DonorCommands","DonorCapes"})
local settingsData = Remote.Get("AllSettings")

The way this should be fixed that the data is lazy leaded while still allowing the userpanel to function.
Even better (though strictly not necessary) is that data that is being loaded is shown via UI in their respective UI elements (like a Loading... text, a spinning loading icon etc.).
And it would even nicer if you could still modify client settings, aliases and keybinds while the data is still loading.

@ccuser44 ccuser44 added the 🐛 bug Bugs or broken features label Jan 21, 2023
@Dimenpsyonal
Copy link
Member

bold of you to assume that we still care about bugs

@Expertcoderz Expertcoderz added ✨ enhancement Enhancing or improving existing functionality 📱 UI Frontend Adonis user interfaces 📝 minor Very small, narrow or generally unimportant issues/enhancements labels Jan 26, 2023
@Expertcoderz
Copy link
Contributor

Annoyingly long UI load times has, to be honest, been an Adonis issue for quite an eternity already.

I'm planning on working on a remedy for this, soon.

@Dimenpsyonal
Copy link
Member

Annoyingly long UI load times has, to be honest, been an Adonis issue for quite an eternity already.

I'm planning on working on a remedy for this, soon.

When???

@Dimenpsyonal
Copy link
Member

Annoyingly long UI load times has, to be honest, been an Adonis issue for quite an eternity already.

I'm planning on working on a remedy for this, soon.

@Expertcoderz are you done yet???? it's been 361 days. time is running out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Bugs or broken features ✨ enhancement Enhancing or improving existing functionality 📝 minor Very small, narrow or generally unimportant issues/enhancements 📱 UI Frontend Adonis user interfaces
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants