Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lazy load userpanel #1407

Merged
merged 8 commits into from
Mar 1, 2024
Merged

Lazy load userpanel #1407

merged 8 commits into from
Mar 1, 2024

Conversation

ccuser44
Copy link
Contributor

Lazy loads the userpanel preventing a delay that can last for many seconds

Ideally this should be element specific but whatever

Fixes #982

@Dimenpsyonal Dimenpsyonal added ✨ enhancement Enhancing or improving existing functionality ⌛needs PoF This PR is awaiting proof of functionality labels Feb 16, 2024
@ccuser44
Copy link
Contributor Author

PoF:
image

@ccuser44
Copy link
Contributor Author

PoF handler fail :(

Dimenpsyonal
Dimenpsyonal reviewed Feb 16, 2024
View reviewed changes
MainModule/Client/UI/Default/UserPanel.lua

Variables.Aliases = playerData.Aliases or {}

local commandPrefix = ":"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

woah woah woah whats this. what about when the prefix isn't :

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what happened to chatMod??????? GRRRRRRR

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

who knows

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

or you can just
image

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Exactly

@Dimenpsyonal Dimenpsyonal added 📱 UI Frontend Adonis user interfaces and removed ⌛needs PoF This PR is awaiting proof of functionality labels Feb 16, 2024
@Dimenpsyonal
Copy link
Member

cannot merge until fixed lol

@P3tray
Copy link
Contributor

P3tray commented Feb 26, 2024

cannot merge until fixed lol

image

@EasternBloxxer
Copy link
Contributor

implemented to astra.

@ccuser44
Copy link
Contributor Author

cannot merge until fixed lol

There is nothing to be fixed anymore

@EasternBloxxer
Copy link
Contributor

cannot merge until fixed lol

There is nothing to be fixed anymore

hardcoded prefix?

@Dimenpsyonal
Copy link
Member

Exactly

@P3tray
Copy link
Contributor

P3tray commented Feb 27, 2024 •
edited
Loading

cannot merge until fixed lol

There is nothing to be fixed anymore

There is nothing he can do.
image

@ccuser44
Copy link
Contributor Author

cannot merge until fixed lol

There is nothing to be fixed anymore

hardcoded prefix?

It's not hardcoded
It still gets the prefix from the server

The default value is just a temporary placeholder till the server responds

@Dimenpsyonal
Copy link
Member

And yet

@EasternBloxxer
Copy link
Contributor

cannot merge until fixed lol

There is nothing to be fixed anymore

hardcoded prefix?

It's not hardcoded
It still gets the prefix from the server

The default value is just a temporary placeholder till the server responds

Or yoy could make it get the prefix when you press the button

@P3tray
Copy link
Contributor

P3tray commented Feb 29, 2024

cannot merge until fixed lol

There is nothing to be fixed anymore

hardcoded prefix?

It's not hardcoded
It still gets the prefix from the server
The default value is just a temporary placeholder till the server responds

Or yoy could make it get the prefix when you press the button

or we could merge it because the pr works probably idk test nightly and be done with this

@Dimenpsyonal
Copy link
Member

Adonis_PRSnapshot_2024-02-27_eb2065d.zip

test it yourself smnh

@Dimenpsyonal Dimenpsyonal merged commit 3b3c39b into Epix-Incorporated:master Mar 1, 2024
2 checks passed
@P3tray
Copy link
Contributor

P3tray commented Mar 4, 2024

Adonis_PRSnapshot_2024-02-27_eb2065d.zip

test it yourself smnh

zip bomb!!!!!

@Dimenpsyonal
Copy link
Member

not gonna lie this looks kinda ugly. i should add a setting in client to toggle this

@P3tray
Copy link
Contributor

P3tray commented Mar 4, 2024

not gonna lie this looks kinda ugly. i should add a setting in client to toggle this

orangutan-hammer

@Dimenpsyonal
Copy link
Member

Boom. Ez fix

@Dimenpsyonal
Copy link
Member

i am truly a coding pro

@ccuser44 ccuser44 deleted the patch-1 branch March 6, 2024 06:52
Dimenpsyonal added a commit that referenced this pull request Mar 11, 2024
@Dimenpsyonal @DrewBokman
@RadiantUwU @ccuser44 @fxeP1 @karl-police @kaiserandaxl @joritochip @YetAnotherClown @coasterteam
Push v252 master to release (#1441)
96cfdd7 
* v252 changelog

* Update version to v252

* Add Dangerous as command option

* Add Dangerous to command t.bool

* Disable R15 dog

* Make Output functions actually work

* Add colon

* Add output title

* Add output title

* Update output titles

* Made ping readout show in ms (#1420)

Before it would always show 0, this remedy's that

Also sunk in a little grammar fix

* Update Changelog

* Add Dangerous command option (#1418)

* Add WarnDangerousCommand to defaultsettings

* Add WarnDangerousCommand to settings

* Add Dangerous as command option

* Fix !rejoin regarding max player server count (#1415)

* Disable !rejoin when player count is equal or greater than max server players

This is to patch a bug inside roblox where players can have way too many players in it.

* Update DefaultSettings.lua

1/2

* Update DefaultSettings.lua

1.5/2

* Update settings.lua

1.75/2

* Implement setting to disable rejoin at max players

2/2

* Add DisableRejoinAtMaxPlayers to Order and Descs

* Add DisableRejoinAtMaxPlayers to order and descs

---------

Co-authored-by: Dimenpsyonal <64012878+Dimenpsyonal@users.noreply.github.com>

* Update Changelog

* Lazy load userpanel (#1407)

* Lazy load userpanel

* Update UserPanel.lua

* Fix missing variable

* Optimise code

* Fix invalid properties

* Fix hardcoded prefix

* Only get variables if there is a window

* Re-add hardcoded prefix

---------

Co-authored-by: Dimenpsyonal <64012878+Dimenpsyonal@users.noreply.github.com>

* Update Changelog v252

* Update Functions output

* Update ScriptEditor output

* Delete MainModule/Server/Plugins/ServerNewDex.rbxmx

* Update newdex

Remove capitalisation from commands and add :newdex as a command

* Update changelog

* Add title to WindowsXP output

* Turn richtext on for windowsXP

* Add

* Add additional Output features to Steampunk

* Add additonal Output features to Rounded

* Add additional output functions to Aero

* Add additional output functions to Unity

* Update Changelog

* Disable singer by default

* Keybinds input fix (#1422)

* Keybinds input fix

Fixes issue where after selecting a key it would still continuously wait for keys to be input.

* Small Old logs fix

Should check if it's a string instead of any other type.

* Update Changelog

* Add Setting "ChatCreateRobloxCommands" to configure whether or not one wants Roblox Chat Commands to be generated (#1423)

* Add "ChatCreateRobloxCommands"

* Add "ChatCreateRobloxCommands"

* Setting "ChatCreateRobloxCommands" to determine whether or not to create Roblox Chat Commands

* Add a setting to determine whether or not to create Roblox Chat Commands

* Update Changelog

* Add FastLoadUserpanel to variables

* Add FastLoad Userpanel to client settings

* Add default value if var is blank

* Fix typo

* Option to disable FastLoad

* Update logic

* Silence playerdata error

* Silence errors

* Update Changelog

* Change meta files from Disabled to Enabled (#1424)

* Update enabled to disabled

* Swap around layout

* Update Changelog

* Fix text being editable in lists (#1425)

* Update Changelog

* Make dangerous commands prompt before being executed. (#1426)

* Add mark as dangerous functionality

* Fix linter issue

* Add WarnDangerousCommand setting

* Add dangerous tags to commands.

* Move dangerous command warning from `Admin.RunCommandAsPlayer` to `Process.Command`

* Fix linter errors.

* Whoops, haven't seen that one.

* Remove dangerous checks from direct ban related commands.

* Bug fixes.

Co-authored-by: fxeP1 <fxe@riseup.net>

---------

Co-authored-by: fxeP1 <fxe@riseup.net>

* Update description of `:nil` command. (#1427)

* Deprecate :nil

* Update Admins.lua

* Update Changelog

* Update Changelog, include contributors

* Move the sword command into fun commands. (#1428)

* Revert "Fix text being editable in lists (#1425)" (#1432)

This reverts commit 99ff7e0.

* Update Changelog.

* Update Changelog

* Read HttpEnabled directly

* Fix :unfly command not working when SignalBehavior is set to Deferred (#1436)

* Update Changelog

* Remove fastload setting and change loading from ugly text to responsive and beatiful icon (#1434)

* Remove `fastloaduserpanel`

* Remove `fastloaduserpanel`

* Remove `fastloaduserpanel`

* Change loading from text to icon

* Fix typo

* Fix rejoin, again, now another command. (#1438)

* Untrack fix for specific players (#1440)

Resolves issue where missing `_` would prevent the "untrack" command from properly removing the tracking instance.

* Use :GetNetworkPing() accurately (#1439)

* Update Changelog.lua

* Fix title logic

* Fix title logic

* Update title logic

* Update title logic

* Update title logic

* Update title logic

* Update Changelog date and time

* Update Anti_Cheat.lua

---------

Co-authored-by: Drew Bokman <61132894+DrewBokman@users.noreply.github.com>
Co-authored-by: Radiant <69520693+RadiantUwU@users.noreply.github.com>
Co-authored-by: ccuser44 <68124053+ccuser44@users.noreply.github.com>
Co-authored-by: fxe <fxep1@riseup.net>
Co-authored-by: karl-police <karl-police2001@bluewin.ch>
Co-authored-by: kaiserandaxl <122803145+kaiserandaxl@users.noreply.github.com>
Co-authored-by: fxeP1 <fxe@riseup.net>
Co-authored-by: joritochip <83682212+joritochip@users.noreply.github.com>
Co-authored-by: Clown <fatestheadfatheadgaming@gmail.com>
Co-authored-by: Coasterteam <21298244+coasterteam@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dimenpsyonal Dimenpsyonal Dimenpsyonal left review comments

@EasternBloxxer EasternBloxxer EasternBloxxer left review comments

@P3tray P3tray P3tray left review comments

Assignees
No one assigned
Labels
✨ enhancement Enhancing or improving existing functionality 📱 UI Frontend Adonis user interfaces
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

User panel takes too long to load
4 participants
@ccuser44 @Dimenpsyonal @P3tray @EasternBloxxer